aboutsummaryrefslogtreecommitdiffstats
path: root/keyboards
AgeCommit message (Collapse)Author
2019-06-28[Keymap] Added 'Vega' ErgoDone layout (#6196)Gravatar Vega Deftwing
* Added 'Vega' ErgoDone layout * Changed as to Fauxpark's recomendations * removed unused custom_keycodes
2019-06-28[Keymap] mitosis:datagrok: use non-copyrighted songs, add workman ditty (#6205)Gravatar Michael F. Lamb
2019-06-26[Keyboard] Add Pulse 4k, a macropad by Maxr1998 (#6195)Gravatar Max Rumpf
* Add Pulse 4k, a macropad by Maxr1998 * Some config tweaks * Remove image note * Add license headers * Fix media keys * Remove Play/pause again as it doesn't work on Linux
2019-06-26[Keyboard] Add Hnah40 keyboard (#6183)Gravatar vuhopkep
* Add Hnah40 keyboard Adding new keyboard Hnah40, open source hardware * update infor * make code looks neater * move to handwired board move and update readme file * update * update * update image * change bootloader type * last change
2019-06-26[Keyboard] Refactor of onekey to support multiple development boards (#6017)Gravatar Joel Challis
* Initial refactor of onekey to support multiple development boards * Fixes to get teensy lc && 3.2 working * Add pin tables * Add caveats to Teensy boards * Correct bootloader for Elite-C
2019-06-26[Keymap] kifinnsson's Colemak angle mod ansi-ish layout for the dz60 (#6191)Gravatar kifinnsson
* [Keymap] kifinnsson's dz60 keymap kifinnsson's custom keymap for the dz60 * Update keyboards/dz60/keymaps/kifinnsson/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Fixed readme.mk cleaned up my readme.mk * fixed readme.mk
2019-06-26[Keyboard] Add keyboard "suihankey" (#6184)Gravatar kakunpc
* new keyboard suihankey * set split keyboard * set default keymap * fix keymap * update default rules.mk * I erased what I didn't need. * Fix default keymap * fix config * add keyboard image url * Update readme.md * update README.md * add info.json * Update keyboards/suihankey/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * remove default RGBLIGHT on
2019-06-26[Keymap] miryoku layout (#6171)Gravatar Manna Harbour
* First release * add "#pragma once" to config.h and related docs * generate config.h with change from miryoku.org
2019-06-26[Keyboard] Modernize KMAC (#6131)Gravatar Mathias Andersson
* [Keyboard] Modernize the KMAC implementation This brings the matrix implementation more in line with the current default matrix code. It also simplifies the implementation quite a bit. * [Keyboard] Add layout support to KMAC
2019-06-25[Keymap] use lowercase send_string for non-literals (#6193)Gravatar Callum Oakley
2019-06-24[Keyboard] Cannonkeys Instant60 Configurator updates (#6186)Gravatar noroadsleft
* Rename layout macros The Instant60's info.json was updated in #6157. The intention seems to have been supporting Community Layouts, but that feature was not implemented. After checking that the layouts conform, rename the appropriate layout macros. - rename LAYOUT_ansi as LAYOUT_60_ansi - rename LAYOUT_tsangan as LAYOUT_60_tsangan_hhkb - update `default` and `tsangan` keymaps * Enable Community Layout support Supported Community Layouts: - 60_ansi (Instant60 ANSI version) - 60_tsangan_hhkb (Instant60 Tsangan version)
2019-06-24[Keymap] the results of some experiments and radically simplify keymap.c (#6172)Gravatar Callum Oakley
* keymap simplification and fancy alt tab behaviour * move symbols around and try ergo numbers * mess with symbol positions * f11 and f12 for volume control (for ease of remapping) * slack unread navigation * experiment with mods on home row * mods on symbol layer * dedicated tab left and tab right keys * swap next and prev * remove hold to shift on a and o * revert to simpler keymap * restore readme * point to keymap image * cmd + cmd -> cmd + ctrl * expand readme * slack unread channel navigation * Update keyboards/planck/keymaps/callum/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * return true from cmd handling block
2019-06-24[Keyboard] Added 3d printable, handwired numpad by tritiumfusion (#6125)Gravatar Agent Blu, 006
* Added tritium_numpad Adding tritium numpad handwired 6x4 numpad design from thingiverse user tritiumfusion. * Updated readme with more tritiumfusion information * Changed spacing in readme * Changed blu keymap * Update keyboards/handwired/tritium_numpad/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/keymaps/max/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/tritium_numpad.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/tritium_numpad.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/tritium_numpad.h Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/keymaps/ortho_left/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/keymaps/ortho_right/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update keyboards/handwired/tritium_numpad/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/handwired/tritium_numpad/rules.mk Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/handwired/tritium_numpad/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Removed action_function(), function_id, and MODS_CTRL_MASK * Reformatted keymaps so that they look nicer. Removed hackey backslashes that were there for no reason whatsoever. * Update keyboards/handwired/tritium_numpad/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Removed more backslashes * Added bootmagic to tritium_numpad
2019-06-24[Keyboard] Add TA-65 PCB to QMK (#6180)Gravatar Yan-Fa Li
* [keyboard] TA-65 by maartenwut Add ta65 to QMK with 4 layouts * Simplify config.h * Simplify keymap * Update bootloader - confirmed to be qmk-dfu by maartenwut * Update keyboards/ta65/readme.md Co-Authored-By: fauxpark <fauxpark@gmail.com> * Review feedback - fauxpark recommendations - noroadsleft recommendations * Repair info.json structure JSON objects were not properly nested according to the QMK specification. * Switch info.json to "debug linting" So I can read the file more easily. * Remove k2c and k31 from LAYOUT_tsangan k2c was the Non-US Hash position, and k31 was the Non-US Backslash position, but this layout is intended for ANSI. * Correct LAYOUT_tsangan data in info.json * Update tsangan keymap to use updated LAYOUT_tsangan macro correctly * Rename LAYOUT_tsangan to LAYOUT_ansi_tsangan Increased clarity. * Rename tsangan keymap as default_ansi_tsangan Per QMK Keyboard Guidelines. * Fix object ordering for ISO layouts in info.json ISO Enter's object was out of sequence in both layouts. * Rename ISO keymaps per QMK Keyboard Guidelines - rename iso keymap as default_iso - rename iso_tsangan keymap as default_iso_tsangan * Add default_ansi keymap For user reference. * Enable Community Layout support LAYOUT_ansi and LAYOUT_iso conform to the 65_ansi and 65_iso Community Layouts, respectively. - rename LAYOUT_ansi to LAYOUT_65_ansi - rename LAYOUT_iso to LAYOUT_65_iso - update keymaps as appropriate - add LAYOUTS rule to rules.mk * Disambiguate key labels in info.json * Remove trailing white space from info.json * Update keyboards/ta65/keymaps/maartenwut/config.h Co-Authored-By: Drashna Jaelre <drashna@live.com>
2019-06-24[Keyboard] Fixup RGB Matrix functionality on Planck EZ (#6099)Gravatar Drashna Jaelre
* [Keyboard] Allow RGB Matrix to be disabled on Planck EZ that don't have LEDs * Add function calls to enabled/disable rgb matrix on idle/wakeup
2019-06-24[Keyboard] Add idle/wakeup function calls to Ergodox EZ (#6173)Gravatar Drashna Jaelre
2019-06-24[Keymap] Katana60 custom layout by josefadamcik - MacOS/Linux+Qwerty/Colemak ↵Gravatar Josef Adamčík
support (#6178)
2019-06-24[Keyboard] Add Ortho75 (#6177)Gravatar Andrew Kannan
* Add Ortho75 * fix typo * Add dfu args to rules.mk * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/ortho75/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com>
2019-06-24[Keyboard] Add AN-C PCB (#6157)Gravatar Andrew Kannan
* Add cannonkeys AN-C keyboard * Update Instant60 readme to point to CannonKeys docs * Ortho75 * Update keyboards/cannonkeys/an_c/an_c.h Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/an_c.h Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/keymaps/default/keymap.c Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/keymaps/default/keymap.c Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/keymaps/tsangan/keymap.c Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/keymaps/tsangan/keymap.c Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/rules.mk Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/instant60/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/cannonkeys/an_c/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update readme * Update info.json * Remove Ortho75 and put in a separate branch * Update info.json * remove redundant things * Update keyboards/cannonkeys/an_c/keymaps/default/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update keyboards/cannonkeys/an_c/keymaps/tsangan/keymap.c Co-Authored-By: fauxpark <fauxpark@gmail.com> * Update rules and info.json
2019-06-22[Keymap] add planck/tylerwince (#6169)Gravatar Tyler Wince
* tylerwince keymap added * modifications for PR * remove legacy import * fix some build errors * fix layers * restore custom_keycodes * remove trailing commas * change persistent layer function * update light noeeprom * layer state set user * missing trailing " * changes to single_default_layer * added autoshift and made a couple mods * added planck layout * formatting * reset to upstream * updated some comments * remove EEP_RST * Apply suggestions from code review Co-Authored-By: Drashna Jaelre <drashna@live.com>
2019-06-22[Keyboard] Add new keyboard: Omnikeyish - A replacement PCB for the ↵Gravatar henrikosorensen
Northgate Omnikey family (#6167) * Add omnikeyish keyboard support. * remove out of date comment * PCB Rev 1.1 moved Row5's pin to E6, because the teensy++ hangs an onboard LED off D6. * Move string.h include to .c file * Add pcb kicad link. * Add info.json * Move macro programming to numlock's keyposition, the most useless key on the post model M layout. Force numlock enabled on host at init time, so you're not stuck without a numpad (hopefully) * Make the macro blink function toggle LEDs from their previous state. * Use incorrect but code style compliant opening curly bracing style. * Make PCB rev 1.1 the default Omnikeyish config, as the author has the only rev 1.0 boards that'll ever be. * Fix silly spelling error in 3 defines * First set of review changes. * Layout macro and keymap defined using it. * Layout macros for the northgate factory plates. * minor rearrangements * ALL the layouts. * Forgot ultra-t in info.json
2019-06-20[Keymap] New keymap for crkbd (#6103)Gravatar 4saito5
* New keymap * Update keymap
2019-06-20[Keyboard] fixes for issue with aanzee qmk port (#6159)Gravatar Max
* fixed issue with LED indicators corrected error in info.json * fixed issue with led indictors * added fix for key_count to info.json for westfoxtrot/aanzee * fix to support config.qmk.fm correctly and remove unused key from matrix for westfoxtrot/aanzee * fix for caps_lock led * Update readme.md
2019-06-20Add ergodash layout, update the backlight numbers for the rgb backlight to ↵Gravatar Fredric Silberberg
be the actual intended colors.
2019-06-20[Keyboard] Aeboards Ext65 - New keyboard & Aegis Update (#6127)Gravatar Xelus22
* aegis config update and ext65 added * update readme's * PID ext65 change * fix ext65 config
2019-06-19[Keyboard] Added NK65 Picture in Readme as promised (#6163)Gravatar yiancar
2019-06-19[Keymap] Added Deft layout (#6153)Gravatar Michael Speiser
* Added Deft layout * Updated style and keymap * Updated readme, removed files * Updated readme and keymap * Updated readme * Fixed broken keymap * Fixed a typo in keymap and readme layer images * Fixed a typo in readme * Embedded layout image for readme * Embedded layout image for readme * Embedded layout image for readme * Fixed typos in keymap Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Fixed typo in keymap Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Fixed typo in keymap Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Fixed a spelling error in the readme * Typos and formatting in readme Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> Co-Authored-By: fauxpark <fauxpark@gmail.com>
2019-06-19[Keyboard] 1up60hse: Add RGBLIGHT_SLEEP To Default Config (#6164)Gravatar Alex Mayer
2019-06-19[Keymap] Actually swap space and left control in gaming mode (#6162)Gravatar Max Rumpf
2019-06-19[Keyboard] Planck Layout Macro Refactor, Part II (#6156)Gravatar noroadsleft
* Move layout macros to revision folders * Update Planck EZ layout macros Planck EZ only supports one layout (centered 2u spacebar). Deleted all the other macros. * Flesh out QMK Configurator support Give each Planck revision its own info.json file. * Readme updates - give each revision its own readme - add the Planck EZ to the main Planck readme * Fix layout macro for Planck EZ Previous matrix didn't compile because the electrical matrix defined a k3b location, which was unused by the physical arguments. Drashna was kind enough to confirm the Planck EZ's matrix for me. Co-authored-by: Drashna Jaelre <drashna@live.com> * Pretend the Planck EZ supports ortho_4x12 layout The hardware doesn't, but doing so prevents CI errors because the default keymap uses LAYOUT_planck_grid. Going to pretend LAYOUT_ortho_4x12 is a valid layout for the Planck EZ. * Update Planck EZ's URL in info.json Co-Authored-By: Drashna Jaelre <drashna@live.com>
2019-06-18[Keyboard] Fix incorrect RGBLED_NUM value (#6148)Gravatar Jimmy Multani
KBD67 Rev 2 has 20 LEDs, not 18. This was causing 2 of the underglow LEDs to remain off. This fix updates that.
2019-06-18[Keymap] Add new mod tap dances to Hacker Dvorak (#6155)Gravatar Ismael Venegas Castelló
2019-06-18[Keyboard] added custom keyboard (#6141)Gravatar joelproko
* added keyboard_layout_jopr * making it compile * #pragma once instead of #ifndef and #define * renamed and added keymap renamed old "default" to "modded_white", added new "default" that resembles an ISO 105-key layout * reordered keyboards/jopr/info.json to match order o layout array * implemented most suggestions * fixed missing ; * fixed bootloader setting for rules.mk * adopted standard layout matrix naming convention * "fixed" commented-out code in keymaps * changes to keymap layers and LEDs Turns out adding a layer for ROYA-modified keycodes is more trouble than it's worth and works better by just defining a ROYA key. Also, LEDs were set up incorrectly. Lastly, implemented SysReq-Warning LED. * moved forced NumLock code just in case either it or the CapsLock & ScrlLock update code wouldn't both work otherwise * rearranged media keycodes * replaced Shifted keycodes with basic ones * Apply suggestions from code review Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * implemented suggestions by noroadsleft * Apply suggestions from code review Make ISO-Enter QMK Configurator-friendly Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update readme.md * Update keyboards/jopr/info.json Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * moved keyboard to handwired folder It was said that personal passion projects belong in there, even if they're not actually handwired * Update readme.md
2019-06-18[Keymap] Add keymap for keebio/nyquist (#6144)Gravatar George Petri
* duplicate default * delete colemak, dvorak * cleanup * update keymap * disable unused rules, fix spit leds * ascii layout keymap * wip change rgb on layer * change rgb on layer * change rgb on caps lock * add impl navigation layer * add readme, swap gui and alt * update readme * Update keyboards/keebio/nyquist/keymaps/georgepetri/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/keebio/nyquist/keymaps/georgepetri/readme.md Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * remove backslashes, use IS_HOST_LED_ON
2019-06-17[Keymap] Update to personal keymaps (#6142)Gravatar M-AS
* added personal CTRL keymap * added personal dz60rgb keymap * enabled new rgb effect * added space cadet shift * media player track buttons now orange * updated keymaps with rgb setting and visual HSV setting preview * fixed source stuff? * added support for underglow toggle (bugged to all hell) * everything now behaves as expected when ti comes to RGB toggles, thank god * removed ifdefs * changed color of MAS_CRM * uh, whitespace * changed rgb positions and modifiers within RGB matrix thing for CTRL and DZ60RGB * updated keymap to work kindof * KEYMAP: changed list of rgb effects * changed CTRL rgb defaults * KEYMAP: new LED layout for ctrl * fixed white LED position in indicator * changed capslock tap timing
2019-06-17[Keymap] 40percent/gherkin Midi Layout (#6130)Gravatar Scott Sheffield
* Add midi layout for 40percent/gherkin * Add readme for 40percent/gherkin:midi
2019-06-16[Keymap] Layout for FC660C with additions for mouse keys and few other ↵Gravatar Sid Carter
changes (#6139) * new keymap for the hasu with media keys and mac layout * switch escape and grave * switch to the usual default * with play and stop * add reset on fn layer * add mouse buttons, move reset, update copyright
2019-06-16[Keymap] Update to personal keymaps (#6136)Gravatar SpacebarRacecar
* changes to keymaps * changes to userspace * changes to userspace * removed reference to fc660c keymap which no longer exists from userspace readme * removed preonic keymap
2019-06-16KB_B should read KC_BGravatar Oliver Ladner
2019-06-16PoC weeheavy_2.25_lshiftGravatar Oliver Ladner
2019-06-16[Keymap] Minor userspace and Quefrency keymap fixes (#6134)Gravatar Jonathan Rascher
* Fix typo for RGBLIGHT config values It doesn't make a difference right now since these are the defaults in rgblight.h (which I'm just setting explicitly since some of the keyboard configs change these defaults). However, I'd rather be explicit, so fixing my typo. :) * Remove mouse keys layer from Quefrency keymap It's a fun idea, but I never use it in practice.
2019-06-16[Keymap] Fix firmware errors when flashing Rev6 Planck (#6135)Gravatar Rob Hilgefort
2019-06-13[Keyboard] Made it possible for real to choose register on io expander for ↵Gravatar roggan87
cols and rows (#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
2019-06-13[Keymap] add new planck keymap (#6122)Gravatar Nicholas Ryan
* add new planck keymap * add newlines to end of files
2019-06-13[Keymap] add keymap hecomi alpha (#6115)Gravatar kakunpc
* add keymap hecomi alpha * Update keyboards/hecomi/keymaps/kakunpc/keymap.c Co-Authored-By: Drashna Jaelre <drashna@live.com>
2019-06-12[Keyboard] Planck: Layout Macro Refactor (#4402)Gravatar noroadsleft
* Planck: layout macro refactor Unified layout macro names across AVR and ARM boards. Currently certain layout macros are specific to either AVR or ARM when used in the QMK Configurator. If an AVR-specific macro is used for a Planck rev. 6, or an ARM-specific macro on a rev. 5 or earlier, the user receives a compile error. * Update keyboards/planck/planck.h per @drashna Changed KC_LAYOUT_ortho_4x12 alias to LAYOUT_kc_ortho_4x12. Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Add KC_KEYMAP alias for LAYOUT_kc macro per @drashna Update keyboards/planck/planck.h Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com> * Fix LAYOUT_planck_1x2uC macro for Planck rev6 Thanks to drashna for testing. * Fix inline comment regarding revisions * Add specific info.json file for Planck rev6
2019-06-11[Keymap] New planck keymap (#6093)Gravatar mgalisa
* New keymap * Add readme; fix lack of asterisk on raise * Update default planck map to tap_code vs reg/unreg * Press F to pay respects
2019-06-11[Keymap] Adding personal keymap / clarifying default keymap readme (#6119)Gravatar brickbots
* Adding led support for Plaid * Adding led support for Plaid * Update readme.md Fixing bad markdown * Adding my personal keymap * Clarifying LED instructions / formatting
2019-06-11[Keymap] Add BB8520 trackpad support for CrKbd (#5925)Gravatar Volodymyr Lukashevych
* Add vlukash CrKbd keymap to support trackpad adapter. The trackpad adapter uses Elite-C board that has five extra pins. Also SPI pins are taken for trackpad, keymap config updates column data pins for matrix scan. * Update vlukash keymap * Enable pointing devide, configure mouse BTN1 * Set TAPPING_TERM to 300 * Add support for the BlackBerry 8520 trackpad * Add vlukash keymap for master-right no-trackpad version * Remap backspace * Set EXTRAKEY_ENABLE = yes * Update thumb keys mappings * Set bootloader to atmel-dfu * Sync keymap * Add scrolling support * Make debug LEDS conditional * Add support for both flex and no-flex PCBs * Add readme and rename root folders * Update readme file with blog link * Fix readme file formatting * Remove ADJUST keycode, code cleanup. * Add Win key to the keymap.
2019-06-11[Keyboard] Added idb 60 keyboard (#5994)Gravatar pngu
* Added idb 60 keyboard * fixed info.json * implemented revievers' suggested changes * fixed an error * implemented revievers' suggestions * further cleanup * implemented suggested changes * fixed errors
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2024-12-29 01:16:31 +0000