From f6b5f6db7665512cece0223ce4d19c5b17455ef4 Mon Sep 17 00:00:00 2001 From: Drashna Jaelre Date: Fri, 15 Nov 2019 14:27:46 -0800 Subject: Improvements to Solenoid feature (#7369) * Error out when Solenid pin is not defined Instead of defaulting to a (literally) random pin, error out instead. Because this pin may be used, or because that pin may not be exposed, or may not exist. * Remove 'SOLENOID_ACTIVE' setting since it's not used * Update documentation --- drivers/haptic/solenoid.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'drivers/haptic/solenoid.h') diff --git a/drivers/haptic/solenoid.h b/drivers/haptic/solenoid.h index 53dc626e3..dd6ececa6 100644 --- a/drivers/haptic/solenoid.h +++ b/drivers/haptic/solenoid.h @@ -29,12 +29,8 @@ # define SOLENOID_MIN_DWELL 4 #endif -#ifndef SOLENOID_ACTIVE -# define SOLENOID_ACTIVE false -#endif - #ifndef SOLENOID_PIN -# define SOLENOID_PIN F6 +# error SOLENOID_PIN not defined #endif void solenoid_buzz_on(void); -- cgit v1.2.3-70-g09d2