subsurface.git, branch v2.0

Turn menu and button images on regardless of OS settings.

2012-10-05T20:26:55Z

Right now the menu and button images are a distribution choice - some have them on, some have them off. I kinda like them and think that even on OSs that have them off by default this doesn't look out of place (as other apps clearly do the same). Signed-off-by: Dirk Hohndel

Added unicode support for the configuration entries on Windows

2012-10-05T14:44:54Z

windows.c: Windows's registry (which is technically a filesystem) uses UTF-16 for its "keys". This forces us to convert each of our UTF-8 (GLib, GTK) configuration entries if we want to store special characters. To do that we use the RegQueryValueExW() and do some conversation around the function call itself. The opposite happens when we require a UTF-16 value to be read from the registry and converted to UTF-8 in subsurface_set_conf(). An addition to this patch is a somehow expandable buffer in windows.c: subsurface_get_conf(). We increase the size of the buffer in chunks of 64 bytes, until RegQueryValueExW() is able to write to it (as suggested by the WINAPI documentation). Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Fixed some memory leaks related to string configuration entries

2012-10-05T14:44:37Z

Each time we retrieve a string configuration entry via subsurface_get_conf(), all the multiplatform methods in linux.c, macos.c, windows.c allocate memory for the returned value. In gtk-gui.c, lets try to release the memory at: default_dive_computer_vendor, default_dive_computer_product, divelist_font before assigning a new address to these pointers. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Provide a method to use unicode command line arguments on Windows

2012-10-04T10:12:19Z

For unicode command line characters Windows uses UTF-16, while Glib and GTK use UTF-8. To solve that we retrieve the command line via __wgetmainargs() and use g_utf16_to_utf8() to convert each argument. The used method should support wildcards passed as arguments (e.g. *.xml). Two new, OS abstracted functions appear in linux.c (NOP), macos.c (NOP), windows.c: subsurface_command_line_init(...) subsurface_command_line_exit(...) which are being called in main() Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Force subsurface.sh on Mac to use bash

2012-10-04T10:07:22Z

This was in a patch set from Henrik but got dropped at first while we explored a different solution. So now it comes back as maybe the most trivial commit, ever :-) Signed-off-by: Henrik Brautaset Aronsen Signed-off-by: Dirk Hohndel

Add readme file for MacOSX package

2012-10-04T10:01:27Z

There are a couple of gothas on MacOSX involving GateKeeper on Mountain Lion, and dialogues that sometimes doesn't pop up. This file explains that. The file should be included in the DMG, but that's for a different commit. [Dirk Hohndel: fix whitespace and some rephrasing] Signed-off-by: Henrik Brautaset Aronsen Signed-off-by: Dirk Hohndel

Use GLib's g_fopen() and g_open() when working with files

2012-10-04T09:43:10Z

On Windows, the GLib wrappers for fopen() and open() deal with the UTF-8 format used for file names when we have to open or save a file with unicode characters in its name. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

More fixes to MacOS bundle file and README

2012-10-02T19:13:19Z

This still seems to fail to open the icon in the About screen in some cases, but we don't quite understand why... Signed-off-by: Dirk Hohndel

Fix typos for MacOSX packaging scripts

2012-10-02T18:12:28Z

Fixed a couple of typos. [Dirk Hohndel: I took the typo fixes, but not the change of shell used; rewrote the commit message accordingly] Signed-off-by: Henrik Brautaset Aronsen Signed-off-by: Dirk Hohndel

Rename Import XML File menu entry

2012-10-02T18:11:21Z

Renamed to "Import XML File(s)", since we can import more than one file. H From 8f9b11d940d903316dcf4d023e327f365e4f4ccb Mon Sep 17 00:00:00 2001 From: Henrik Brautaset Aronsen Date: Tue, 2 Oct 2012 11:38:56 +0200 Subject: [PATCH] Rename Import XML File menu entry Renamed to "Import XML File(s)", since we can import more than one file. Signed-off-by: Henrik Brautaset Aronsen Signed-off-by: Dirk Hohndel