subsurface.git, branch v3.0.2

Improve pane position saving code

2013-03-04T08:26:32Z

We should test for being in PANE_THREE mode in save_pane_position() and replace the if()'s testing against window geometry. This eliminates some code duplication and, more importantly, save_pane_position() is also called from save_window_geometry() whose calling pattern is not obvious. Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel

Update README, ReleaseNotes and Makefile for 3.0.2

2013-03-04T07:49:32Z

Signed-off-by: Dirk Hohndel

Saving individual dives should not change the exiting filename

2013-03-04T07:31:24Z

The current data file is not the same as the file to which individual dives were saved. Reported-by: Jan Schubert Signed-off-by: Dirk Hohndel

Fix scaling problem in scrolled edit dialog

2013-03-04T06:30:55Z

With this change resizing the dive edit dialog once again has its content resize as well. So now we have the best of both worlds: if the content grows we add scroll bars (so things stay usable on small screens), yet when we resize the window, the notes area gets nice and big (which is great on big screens). Signed-off-by: Dirk Hohndel

Only store pane positions if we currently display "View Three"

2013-03-04T05:07:09Z

We tried to detect this without needing a global variable but that clearly was too dependent on decorations that the window manager might add. This code works reliably. Signed-off-by: Dirk Hohndel

Try to capture some more potential buffer overflows caused by localization

2013-03-04T04:18:23Z

A couple of these could clearly cause a crash just like the one fixed by commit 00865f5a1e1a ("equipment.c: Fix potential buffer overflow in size_data_funct()"). One would append user input to fixed length buffer without checking. We were hardcoding the (correct) max path length in macos.c - replaced by the actual OS constant. But the vast majority are just extremely generous guesses how long localized strings could possibly be. Yes, this commit is likely leaning towards overkill. But we have now been bitten by buffer overflow crashes twice that were caused by localization, so I tried to go through all of the code and identify every possible buffer that could be affected by this. Signed-off-by: Dirk Hohndel

Extending user manual

2013-03-04T00:01:49Z

Adding UDDF support for DR5, kenozooid and in general, fixed some things, updated to 3.0.2 Signed-off-by: Jan Schubert Signed-off-by: Dirk Hohndel

equipment.c: Fix potential buffer overflow in size_data_funct()

2013-03-03T23:33:24Z

strcpy() with buffer[10], could overflow on most languages. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel

Fix pane position bug

2013-03-03T19:56:51Z

Argh. Maxint is not at the bottom or at the right. We have to check against the size of the window to determine we are not saving a maximized position. Here is a fix. Signed-off-by: Robert C. Helling Signed-off-by: Dirk Hohndel

Fix ESC key handling in Save dialog.

2013-03-03T18:45:11Z

Closing unsaved dive raises Save dialog with Yes/No/Cancel buttons. Pressing ESC dismisses dialog without saving changes. This commit adds GTK_RESPONSE_DELETE_EVENT response code check in order to fix that behavior. Reported-by: Jan Schubert Signed-off-by: Sergey Starosek Signed-off-by: Dirk Hohndel