subsurface.git, branch v4.0.99

Last minute Beta 4

2014-05-06T18:32:48Z

Signed-off-by: Dirk Hohndel

Only change identical fields when editing multiple dives

2014-05-06T18:13:24Z

This was broken when porting to Qt - we used to do this correctly in the Gtk version. When editing multiple dives we show the current dive to the user and allow them to edit that and then apply those edits to all selected dives. The way this is SUPPOSED to work is that we only change those selected dives that had the same value for the edited field as the current_dive had for that field. Let's say you select ten dives. The current dive shows divemaster Joe. You change that to divemaster Jim. Then only the selected dives that had divemaster Joe should change to Jim. All other dives should stay unchanged. This seems to implement that logic. Signed-off-by: Dirk Hohndel

Change EDIT_SELECTED_DIVES macro

2014-05-06T16:58:27Z

The way this is implemented is broken in several ways. This fixes the first issue. For the invocations where we are in the 'WHAT' checking to see if the value we are changing in the selected dive was previously the same as in the current dive (which is the one shown to the user for editing), then we need to make sure we change the current dive last, otherwise the comparison will fail. Of course, right now we only do this check for gps location, which is a massive bug as far as I am concerned. Fixes #515 Signed-off-by: Dirk Hohndel

Change the profile redraw logic after preferences were changed

2014-05-05T22:58:25Z

I we are showing a calculated ceiling, then we have to replot the profile after a preferences change as the gradient factors could have changed which might change a calculated ceiling. Also use the rulergraph preference instead of checking the settings directly. Fixes #511 Signed-off-by: Dirk Hohndel

Correctly parse boolean preferences

2014-05-05T22:56:49Z

QVariant does the right thing, regardless of whether the value is stored as int or as string - so let's just use that instead of manually checking for integers (and failing if the values are stored as "true" and "false"). Fixes #511 Signed-off-by: Dirk Hohndel

Fix odd indentation

2014-05-05T22:56:11Z

I need to fix this in the tool as well... Signed-off-by: Dirk Hohndel

Make rulergraph a pref as well

2014-05-05T22:53:46Z

I don't see a point in treating it differently from the other graphs. Signed-off-by: Dirk Hohndel

Fix standard cylinder names

2014-05-05T21:52:13Z

We need to pass the size as an integer. Signed-off-by: Dirk Hohndel

Uemis downloader: handle more corner cases

2014-05-05T21:36:55Z

After receiving another report of the Uemis downloader failing I tried to make it more robust when unexpected things happen. The data structures returned by the SDA are rather convoluted and not all relationships are fully understood. This makes sure we don't try to parse invalid dive entries, we only read dive entries if we actually got new divelog entries, we only read dive sites if at least one was referenced and we use a much more patient (and hopefully, much more robust) algorithm to figure out which dive entry corresponds to the new divelog entries. What a pain. Signed-off-by: Dirk Hohndel

Fix bug in handling of fake SAMPLE_EVENT_PO2 events

2014-05-05T16:32:13Z

In commit bcdd6192fe45 ("Show translated event names in tooltip") I was too aggressive in replacing the checking for event names with checking for event types. It turns out that we are abusing an existing event type in the planner (and use a different event name to mark the difference). By just checking for the type this now caused incorrect information to be displayed in the info box (a simply "PO2 warning" on a Suunto D9 could turn into a "Bailing out to OC" notice). The correct fix is to get our own range of SAMPLE_EVENT_xxx numbers from libdivecomputer. Once we have those, we can do this the right way. For now we just fall back to also checking the event name (which is what I wanted to get away from so translated names don't trip us up). Signed-off-by: Dirk Hohndel