subsurface.git, branch v4.8.0

Dive pictures: adjust rowDDEnd and rowDDStart on picture deletion

2018-06-29T05:30:48Z

In DivePictureModel, rowDDEnd and rowDDStart specify the range of pictures in the profile plot. Obviously, these have to be adjusted when pictures are deleted. Signed-off-by: Berthold Stoeger

Latest translations

2018-06-29T00:13:50Z

Signed-off-by: Dirk Hohndel

Dive pictures: connect DivePictureModel signals in constructor

2018-06-29T00:12:19Z

The DivePictureModel signals were connected int the setProfileState() function of ProfileWidget2. If this function was called repeatedly (e.g. after adding a dive), multiple connections were made, which led to multiply delivered signals. This in turn led to confusion, when deleting pictures (i.e. multiple pictures were deleted). Instead, connect once in ProfileWidget2's constructor. It is unclear whether these signals should be disconnected temporarily if no pictures are shown. In any case, the weren't, so this shouldn't introduce any regression. Fixes #1441 Signed-off-by: Berthold Stoeger

Dive pictures: render icons with white instead of transparent background

2018-06-28T13:58:29Z

The SVG icons for failed / still-loading pictures were rendered with an alpha channel. This lead to strange behavior when hovering over the icon in the profile plot: When hitting a "hole" the icon would be minimized again. Therefore, render the SVGs onto a white background. Signed-off-by: Berthold Stoeger

Android: limit the amount of data copied to clipboard

2018-06-28T13:52:14Z

The clipboard fails if we attempt to copy more than 1MB of data. But the data buffer used is shared between all transactions 'in flight' and we cannot tell what else is currently using that buffer. Limiting ourselves to 500k of text for the logfiles seems reasonable and hopefully makes it more likely that the transaction will succeed (sadly, Qt doesn't tell us if it failed). Signed-off-by: Dirk Hohndel

iOS and Android: try more logfile locations

2018-06-28T13:17:31Z

On some devices (e.g., a Sony Xperia phone) the GenericDataLocation is not app writeable. Instead of just giving app, try a few other default locations as well (and since all of these are actually string lists, try all of the options that Qt gives us). Reasonably, we should only set the libdivecomputer logfile name if we found a writeable location. Signed-off-by: Dirk Hohndel

QML UI: provide information why logfile couldn't be written

2018-06-28T12:39:10Z

Signed-off-by: Dirk Hohndel

Add Cressi Giotto, Newton and Drake to list of devices

2018-06-28T03:52:24Z

Adding Cressi Giotto, Newton and Drake to the list of devices that can be selected on Android devices. Signed-off-by: Stephen Goodall

QML UI: fix layout of Download page

2018-06-27T23:28:01Z

The info text from the download process wasn't rendered correctly. maximumWidth ended being a recursive reference and as a result the text would render as very narrow and super-tall field. Signed-off-by: Dirk Hohndel

QML UI: remove unused property

2018-06-27T23:05:36Z

We always save the libdivecomputer log. Signed-off-by: Dirk Hohndel