subsurface.git, branch v4.9.3

More translation updates

2019-09-09T06:41:19Z

Signed-off-by: Dirk Hohndel

Prepare for 4.9.3 release

2019-09-08T14:07:30Z

Signed-off-by: Dirk Hohndel

Latest translations

2019-09-08T14:04:13Z

Signed-off-by: Dirk Hohndel

Update libdivecomputer to latest version

2019-09-07T19:33:45Z

This just merges with Jef's branch, which should hopefully fix the Mares BLUELINK Pro connection issues. Knock wood - I can no longer test it due to lack of hardware. It also improves on the Ratio iDive cylinder pressure transmitter support. Signed-off-by: Linus Torvalds

Dive site: close dive site edit widget when dive site is deleted

2019-09-07T15:28:29Z

The application could be crashed by 1) Create dive site 2) Edit dive site 3) Undo until dive site is removed 4) Continue editing now non-existing dive site Therefore, hook into the dive-site-deleted signal and if the currently edited dive site is deleted, close the widget. When closing the widget, make sure that the potentially dangling pointer is reset to zero so that there is no other potential use-after-free bug. Signed-off-by: Berthold Stoeger

Cleanup: remove unused MapWidget::repopulateLabels() function

2019-09-06T18:48:47Z

There is the alternative MapWidget::reload() function, which centers on the selected dive-site. Signed-off-by: Berthold Stoeger

Map: remove MapWidget::repopulateLabels() call

2019-09-06T18:48:47Z

For historic reasons MapWidget::repopulateLabels() was called in LocationInformationWidget::acceptChanges(). This should not be necessary anymore, as this is done when entering/exiting dive-site-mode. Signed-off-by: Berthold Stoeger

Map: remove unnecessary MapLocationModel::repopulateLabels() calls

2019-09-06T18:48:47Z

The LocationInformationWidget repopulated the map labels if the name or location of a site changed. This is unnecessary because the MapLocationModel catches these signals itself. Remove these calls. As an added bonus, calling repopulateLabels() in QML context leads to crashes later on. Therefore this should fix at least one crash condition when dragging a flag on the map while the dive-site-edit-tab is shown. Signed-off-by: Berthold Stoeger

Cleanup: remove redundant Roles:: qualifier in maplocationmodel.cpp

2019-09-06T18:48:47Z

"Roles" is a C-style enum (i.e. not C++-style enum class). Since that means that the names spill into the outer namespace, the names themselves are prefixed with "Role". Nevertheless the code qualified the names with "Roles::". This is redundant and unnecessary. Remove this redundancy to show that we understand how the language works. Note: we could also transform the enum into an enum class and remove the "Role" prefix from the names. That would arguably be "cleaner", but then the enum doesn't auto-convert to/from int, but Qt uses int to pass the roles to functions. So let's go the simple way that avoids casting. Signed-off-by: Berthold Stoeger

Cleanup: remove includes from maplocationmodel.cpp

2019-09-06T18:48:47Z

Neither "QDebug" nor "algorithm" were necessary. Signed-off-by: Berthold Stoeger