subsurface.git, branch v4.9.6

pull latest translations from Transifex

2020-06-20T17:52:32Z

Signed-off-by: Dirk Hohndel

update README and ReleaseNotes for 4.9,6

2020-06-20T17:51:48Z

Signed-off-by: Dirk Hohndel

core: fix compile issue with older g++

2020-06-18T16:05:13Z

Having the full list of all members in the exact order should be enough to get g++ to accept the named initializers. Signed-off-by: Dirk Hohndel

core: fix libdivecomputer dc_custom callbacks structures

2020-06-18T16:05:13Z

The last time those changed, we forgot to update serial_ftdi. In that change set_latency had been removed from libdivecomputer and poll and ioctl had been added. This caused the callbacks to no longer be aligned correctly and the functions were called with the wrong arguments through the wrong function pointers, leading to crashes. Instead of the fragile assumptions about order and type of function pointers, use named initializers. And while we are at it, fix that for the bluetooth implementation as well. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

cleanup: remove indirection when passing arguments to parser functions

2020-06-16T15:20:53Z

For unknown reasons, the dive site and trip to be parsed into were passed as pointers to pointers. A simple pointer seems to be enough, since the object is not allocated by the function. Signed-off-by: Berthold Stoeger

Update CHANGELOG

2020-06-14T20:35:33Z

Signed-off-by: Dirk Hohndel

mobile: show sync state in menu plate

2020-06-14T20:35:33Z

This seems like the easiest way to show the state without disrupting the UI elsewhere. Directly below the email address used for cloud storage. Signed-off-by: Dirk Hohndel

mobile: add status text for cloud sync state

2020-06-14T20:35:33Z

This allows the mobile UI to reflect the three states that the dive list can be in: - changes that haven't been written to local storage - there potentially are changes in local storage that were not synced with the cloud - dive list is in sync with cloud storage The last state could be misleading if the user access the cloud from a different device and makes changes to the cloud storage from there, but from the point of view of this device, the states are consistent. Signed-off-by: Dirk Hohndel

mobile: track if we have changes that aren't synced to cloud

2020-06-14T20:35:33Z

If we haven't connected at all to the cloud server we assume that there are local changes. And whenever we save changes only locally, we also set that flag. Signed-off-by: Dirk Hohndel

git-storage: add global flag to indicate successful cloud sync

2020-06-14T20:35:33Z

This may seem like a bit heavy handed as it adds more global state, but given the number of ways in which attempts to sync with the cloud can fail it seems much more reliable to claim success in the spots where we actually know that we have successfully synced with the remote server. Transporting that information back through the various call chains turned out to be very disruptive and ugly, so I went with global state instead. Whenever we access cloud storage (or any git repo), we always first check if it actually is a git repo by calling is_git_repository() - so this is the perfect spot to initialize the variable to false. And there are only two spots where we either clone the remote repo (create_local_repo()) or update the remote with the (potentially merged) local changes (check_remote_status()). So those are the two places where we set the variable to true. Signed-off-by: Dirk Hohndel