subsurface.git/backend-shared, branch v4.9.4

cleanup: move declaration of utc_mk* functions to new subsurface-time.h header

2020-05-01T16:42:31Z

No point in slurping in all of dive.h for translation units that only want to do some time manipulation without ever touching a dive. Don't call the header "time.h", because we don't want to end up in a confusion with the system header of the same name. Signed-off-by: Berthold Stoeger

cleanup: move dive_table from dive.h to divelist.h

2020-05-01T16:42:31Z

This allows us to decouple dive.h and divelist.h, a small step in include disentangling. Signed-off-by: Berthold Stoeger

media: move picture function from dive.c to picture.c

2020-04-10T17:53:03Z

Currently, move only those functions that do not access dive structures. Signed-off-by: Berthold Stoeger

mobile/export: remove most of the export options

2020-02-17T18:50:51Z

A tablet or phone is not a computer. What would you do with a CSV or TeX/LaTeX file on a phone. Yeah, I get it, feature parity. This should never have been merged. Signed-off-by: Dirk Hohndel

Planner: don't filter cylinders

2020-02-12T04:37:09Z

In the planner we used to filter out "unused" cylinders as in the equipment tab. It is unclear whether that makes sense or can even easily be reproduced, since such cylinders have to come from an imported dive. To be on the save side, let's not do this. Replace the CylindersFilteredModel introduced recently by a plain CylindersModel. Signed-off-by: Berthold Stoeger

Planner: make cylinder-model subobject of planner-model

2020-02-12T04:37:09Z

The cylinder-model had an instance() function, but actually there were two cylinder models: one used by the equipment tab, one used by the planner. This is misleading. Therefore, remove the instance() function and make the cylinder-model a subobject of the planner-model. Signed-off-by: Berthold Stoeger

Cylinders: Add CylindersModelFiltered

2020-02-12T04:37:09Z

When the show_unused_cylinders flag is not set, the cylinder tables in the equipment tab and the planner should not show unused cylinders. However, the code in CylindersModel is fundamentally broken if the unused cylinders are not at the end of the list: The correct number of cylinders is shown, but not the correct cylinders. Therefore, add a higher-level CylindersModelFiltered model on top of CylindersModel that does the actual filtering. Some calls are routed through to the base model (notably those that take indexes, as these have to be mapped), for some calls the caller has to get access to the source model first. We might want to adjust this. For filtering, reuse the already existing show_cylinder function and export it via CylindersModel. Signed-off-by: Berthold Stoeger

Cleanup: remove const bool parameters and return types

2020-02-09T20:13:18Z

These just make no sense. Since the value is copied, it has no meaning to the caller whether the function can change the value (and vice versa for return types). Signed-off-by: Berthold Stoeger

Cleanup: only use necessary includes in exportfuncs.h

2020-02-09T20:13:18Z

Forward declare if possible. Signed-off-by: Berthold Stoeger

Cleanup: remove exportFunc class

2020-02-09T20:13:18Z

exportFunc was a collections of functions for exporting dive data. It had no state, therefore there is no reason for it to ever be instantiated. Simply remove the class. Rename the saveProfile function to exportProfile so that all export functions start with "export". Signed-off-by: Berthold Stoeger