subsurface.git/commands, branch v4.9.8

desktop: fix translation implementation

2020-11-08T22:39:26Z

We need to always call the tr() function of the base class. This will have consequences for our translations. See: #3068 Signed-off-by: Dirk Hohndel

cleanup: fix deprecated QVector constructor

2020-10-27T02:27:03Z

Annoyingly, the replacement has only been available since Qt 5.14. To make the code less messy, implement our own stdToQt conversion helper. Suggested-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

cleanup: remove pref.h include in dive.h

2020-10-25T20:59:52Z

If source files want to access preferences functions, they should include pref.h themselves. Signed-off-by: Berthold Stoeger

cleanup: break out event-related code into event.[c|h]

2020-10-25T20:59:52Z

In an effort to reduce the size of dive.h and dive.c, break out the event related functions. Moreover event-names were handled by the profile-code, collect that also in the new source files. Signed-off-by: Berthold Stoeger

undo: add device related undo commands

2020-10-25T20:59:04Z

Add commands for deleting devices and editing device nicknames to include the device-handling in the undo system. Signed-off-by: Berthold Stoeger

devices: add devices in Command::importTable()

2020-10-24T16:51:37Z

Add a device_table parameters to Command::importTable() and add_imported_dives(). The content of this table will be added to the global device list (respectively removed on undo). This is currently a no-op, as the parser doesn't yet fill out the device table, but adds devices directly to the global device table. Signed-off-by: Berthold Stoeger

filter: remove filter_preset_table_t

2020-10-17T16:04:20Z

We used a typedef "filter_preset_table_t" for the filter preset table, because it is a "std::vector". However, that is in contrast to all the other global tables (dives, trips, sites) that we have. Therefore, turn this into a standard struct, which simply inherits from "std::vector". Note that while inheriting from std::vector<> is generally not recommended, it is not a problem here, because we don't modify it in any shape or form. Signed-off-by: Berthold Stoeger

filter: implement importing of filter presets

2020-09-29T23:13:03Z

When importing a divelog, import filter presets. If there are equal names, import only if the presets differ. In that case, disambiguate the name. This made things a bit more complicated, as comparison of filter presets had to be implemented. Signed-off-by: Berthold Stoeger

filter: add filter preset undo commands

2020-09-29T23:13:03Z

Add undo commands to add / edit / delete filter presets. These are styled after the other undo commands: On changes, the UI is informed by DiveListNotifier signals. Editing is a simple std::swap of values. Signed-off-by: Berthold Stoeger

cleanup: remove count_divecomputers() function

2020-09-09T00:20:09Z

There is a number_of_computers() function which does the same thing with two exceptions: 1) checks for null-dive 2) returns an unsigned int Replace calls to count_divecomputers() by calls to number_of_computers(). In one case, the return type makes a different - add a cast to int there. Ultimately, we should probably change the dc_number to signed int throughout the code. Signed-off-by: Berthold Stoeger