subsurface.git/commands, branch v5.0.1

undo: set dive mode to CCR in undo command, not profile code

2021-01-11T17:31:36Z

When setting a CCR setpoint, the profile code(!) would turn the dive into a CCR dive. Not only should the display layer not alter dives, this also means that the action is not undoable. Move that to the appropriate undo command, where it makes more sense, but obviously also makes things more complicated. Signed-off-by: Berthold Stoeger

undo: add missing invalidate_dive_cache() calls

2021-01-11T16:42:17Z

The AddWeight, RemoveWeight, EditWeight and ReplanDive commands were missing invalidate_dive_cache() calls. Add them to ensure that the dives are written to git logs on save. Fixes #3150 Reported-by: Peter Zaal Signed-off-by: Berthold Stoeger

Make sure to sanitize the gasmix after editing it

2021-01-10T21:44:43Z

Otherwise we end up showing the gasmix in a different form after editing for the usual air percentages, because we haven't normalized the gasmix values and store them back in the dive in the non-normalized format. Signed-off-by: Linus Torvalds

filter: internalize shown_dives in DiveFilter class

2020-12-29T16:34:09Z

one piece of global state removed! Signed-off-by: Berthold Stoeger

filter: keep track on shown_dive on dive removal in DiveFilter

2020-12-29T16:34:09Z

When removing dives, the UndoCommands would keep track of the shown dives. When adding, they were calling into the filter instead. Let's remove this asymmetry. Signed-off-by: Berthold Stoeger

undo: fix annoying warning message when deleting pictures

2020-12-19T19:19:51Z

The RemovePictures command filters the pictures provided by the UI: only actually existing pictures are removed. The code was buggy: the original list was copied and then the filtered list was added. Thus, every picture was listed twice leading to annoying warning messages. Remove the copy. Signed-off-by: Berthold Stoeger

undo: add \n to console warning error messages

2020-12-19T19:19:51Z

To make the output more readable. Moreover, fix a comment-typo. Signed-off-by: Berthold Stoeger

core: keep tank infos in a dynamic table

2020-12-13T19:49:59Z

The list of known tank types were kept in a fixed size table. Instead, use a dynamic table with our horrendous table macros. This is more flexible and sensible. While doing this, clean up the TankInfoModel, which was leaking memory. Signed-off-by: Berthold Stoeger

desktop: use getDiveSelection to access selected dives

2020-12-12T23:52:40Z

In the list view two functions were still manually collecting the selected dives. Use getDiveSelection() there as well. Careful: that means that the check for dives that are already outside of a trip now has to be done in the RemoveDivesFromTrip command. Signed-off-by: Berthold Stoeger

undo: add a general dives-imported signal

2020-11-14T18:01:50Z

Add a general dives-imported signal for those cases where we want to fully rebuild models, notably, the completion models. The divesAdded signals are too fine, because they are sent per trip and we don't want to reload these models multiple times per import. Signed-off-by: Berthold Stoeger