subsurface.git/core/subsurface-qt, branch v4.7.6

Cleanup: avoid out of bounds access

2017-12-27T00:06:05Z

sizeof() is clearly the wrong way to get to the size of that array... Coverity CID 208290 Signed-off-by: Dirk Hohndel

Remove obsolete declaration of void gfLowAtMaxDepthChanged

2017-12-23T23:01:39Z

in ./core/subsurface-qt/SettingsObjectWrapper.h Code for this was removed here: 5b080beddef3e08b86eb53448e737b4867a50c1a Signed-off-by: Stefan Fuchs

Fix crash when dives have no dive site

2017-11-25T16:19:47Z

get_dive_site_by_uuid() returns a NULL pointer in that case. Signed-off-by: Dirk Hohndel

mobile: autocomplete location names

2017-11-25T16:13:42Z

Add the capability to select the location name from a list, constructed from the known dive sites in the logbook. Fixes: #546 Signed-off-by: Jan Mulder

Change prefs.show_units_table to bool

2017-11-24T15:56:10Z

Bool is the correct choice for this option. int was used before because it was not clear to me how and if I can use bool in this C file. Signed-off-by: Stefan Fuchs

Make handling of booleans consistent on the C++-side of preferences

2017-11-20T19:56:13Z

In general, the C++-side of the preferences code consistently uses the bool data type for boolean settings. There are five exceptions, which use short instead: showPo2 showPn2 showPhe saveUserIdLocal displayInvalidDives This patch attempts to make the code more consistent by turning these into bools as well. Tests showed that writing as short and reading as bool is handled gracefully by the Qt variant code. Therefore, an upgrade should not cause user-visible changes to their settings. As a bonus, two extern declarations of the set_save_userid_local() function, which is not defined anywhere, were removed. Signed-off-by: Berthold Stoeger

Constify strings in pref.h

2017-11-18T20:57:33Z

Make all char * pointers in pref.h const to make it clear that these strings are not mutable. This meant adding a number of (void *) casts in calls to free(). Apart from being the right thing to do, this commit makes the code more consistent, as many of the strings in pref.h were already const. While touching core/qthelper.cpp turn three instances of (void*) into (void *). Signed-off-by: Berthold Stoeger

Fix memory leaks in SettingsObjectWrapper.cpp

2017-11-17T14:32:38Z

Free a bunch of C-style strings before assigning newly copied strings. One case was particularly buggy: prefs.locale.use_system_language = copy_string(qPrintable(value)); Note that prefs.locale.use_system_language is a bool, which of course always evaluates to true! Probably nobody noticed because a restart is required when changing locale. Moreover remove a few double-semicolons.

Fix typo: LENGHT -> LENGTH

2017-11-17T14:29:42Z

Make Bluetooth naming consistent

2017-11-14T04:48:17Z

Currently, on Linux, after selecting a Bluetooth device the name of the device is shown. On reopening the download dialog, on the other hand, the address is shown. In the device selection dialog both are shown. This patch changes the download dialog such that both, name and address, are shown. The bulk of the patch introduces the name of the device in the preferences and DCDeviceData. It has to be noted that DCDeviceData is an encapsulation of the libdivecomputer device_data_t. Nevertheless, the new Bluetooth-name field is, at the moment, not passed through to libdivecomputer. Signed-off-by: Berthold Stoeger