subsurface.git/core/subsurface-qt, branch v4.7.7

mobile cleanup: restyle construction of locationlist

2018-01-31T13:48:14Z

See also e6e1473e6. The construction of the locationlist was not the same as the 3 previous lists, and it needs the inclusion of a new model file (divelocationmodel.cpp) in the mobile app. In addition, as the mobile app is mainly interested in a simple stringList (model) to populate a HintsText field (or maybe later a combobox), this stringlist is added to the model, to easy interfacing with QML. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (3)

2018-01-31T13:48:14Z

See e6e1473e6. Exact same commit but here for the list of divemaster. The careful reader will spot a small addition to the clearDetailsEdit() QML function. Two more field are cleared. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (2)

2018-01-31T13:48:14Z

See e6e1473e6. Exact same commit but here for the list of buddies. Signed-off-by: Jan Mulder

mobile cleanup: unduplicate code and do not loop over dives (1)

2018-01-31T13:48:14Z

This is the first of a set of commits that are (very) similar. It appeared that a number of more or less static lists, which are constructed by a loop over all dives in the logbook, were executed when changing focus to a next dive. For example, the in this commit addressed list of used dive suits. What was wrong was that the suitList was linked to a dive. There is only a need to construct the list of used suits when data is changed (and obviously, once on startup of the app). Further, it appeared that a lot of code was duplicated and that we can use (in this case) the same code from the desktop completionmodels.cpp. Basically, this commit involves the following changes: - include completionmodels.cpp in mobile and desktop (so move it from the desktop only category to the generic category). - remove double code from DiveObjectHelper.cpp - Do not differentiate in the init phase and the normal refresh of the list - the per dive logic is now only the getting of a previously constructed list (in init or update of the divelist). There are no visible changes in the UI, other than a better performance when scrolling over dive details. Signed-off-by: Jan Mulder

Remove cloud_background_sync preferences option

2018-01-06T18:46:07Z

The preferences flag cloud_background_sync used to be used heavily in the mobile code, but is not used there anymore. Now, it is accessed only in one place, but does not do what it actually says: If it is off, the remote storage is not synced on save (but will be synced on next load). Syncing on save can also be prevented by unchecking the "Cloud online" menu checkbox. Since the latter seems more logical and general (support for non-cloud remote git repositories), remove the cloud_background_sync option. Signed-off-by: Berthold Stoeger

Cleanup: avoid out of bounds access

2017-12-27T00:06:05Z

sizeof() is clearly the wrong way to get to the size of that array... Coverity CID 208290 Signed-off-by: Dirk Hohndel

Remove obsolete declaration of void gfLowAtMaxDepthChanged

2017-12-23T23:01:39Z

in ./core/subsurface-qt/SettingsObjectWrapper.h Code for this was removed here: 5b080beddef3e08b86eb53448e737b4867a50c1a Signed-off-by: Stefan Fuchs

Fix crash when dives have no dive site

2017-11-25T16:19:47Z

get_dive_site_by_uuid() returns a NULL pointer in that case. Signed-off-by: Dirk Hohndel

mobile: autocomplete location names

2017-11-25T16:13:42Z

Add the capability to select the location name from a list, constructed from the known dive sites in the logbook. Fixes: #546 Signed-off-by: Jan Mulder

Change prefs.show_units_table to bool

2017-11-24T15:56:10Z

Bool is the correct choice for this option. int was used before because it was not clear to me how and if I can use bool in this C file. Signed-off-by: Stefan Fuchs