subsurface.git/core/subsurface-qt, branch v4.8.5

Coding style: remove stray ';'

2018-11-13T04:55:41Z

There was a stray semi-colon on the beginning of a line in DiveObjectHelper.cpp. Remove it. Signed-off-by: Berthold Stoeger

Dive list: don't pass dive_site via uintptr_t through QML

2018-10-29T00:09:31Z

Now that struct dive_site * is a proper Q_METATYPE it is not necessary anymore to pass dive-sites as opaque uintptr_t types. Simply pass a QVariants or directly via dive_site *. Signed-off-by: Berthold Stoeger

Dive site: replace dive->dive_site_uuid by dive_site

2018-10-29T00:09:31Z

Replace the UUID reference of struct dive by a pointer to dive_site. This commit is rather large in lines, but nevertheless quite simple since most of the UUID->pointer work was done in previous commits. Signed-off-by: Berthold Stoeger

Dive site: use an array of pointers in reloadMapLocations()

2018-10-29T00:09:31Z

MapWidgetHelper::reloadMapLocations() used an array of uuids to add dive sites to the map only once. Replace this by an array of pointers. This is a small piece of a larger effort to remove dive site UUIDs. Signed-off-by: Berthold Stoeger

Dive site: replace UUID by pointer in mobile code

2018-10-29T00:09:31Z

Replace UUIDs by pointers to dive-site in mobile code. In both cases, the value is transported via a QVariant. The function getCoordinatesForUUID(), which was only used from mobile, can be replaced by a getCoordinatesFor() function taking a variant supposed to contain a dive-site pointer. Likewise, the variant of the centerOnDiveSite function is now supposed to wrap a pointer-to-divesite. Signed-off-by: Berthold Stoeger

core: use nr of dives shown in tripMeta info

2018-10-25T22:24:22Z

When creating a trip header (as it is used in the mobile app right now), we need to show the number of dives shown, not the total number of dives in that trip. Signed-off-by: Dirk Hohndel

core: add ability to get underlying dive to DiveObjectHelper

2018-10-25T22:24:22Z

This feels a bit like cheating, but if we need to be able to make modifications to the underlying dive and only have the helper object (for example inside of a view model), doing everything through the helper object can turn into a real performance issue. Signed-off-by: Dirk Hohndel

Mobile/filtering: add fullTextNoNotes to the dive object helper

2018-10-23T21:45:30Z

This way we can filter with and without the notes. Signed-off-by: Dirk Hohndel

Mobile/filter: add marker between entries in full text search

2018-10-23T21:45:29Z

Otherwise we could match the end of one string and the beginning of the next, so having a buddy name Linus and a dive master named Alvin would be matched by USA. Also add Notes to the full text search (I had forgotten those earlier). Signed-off-by: Dirk Hohndel

Mobile/filtering: full text filter, instead of just dive site

2018-10-23T21:45:29Z

Signed-off-by: Dirk Hohndel