subsurface.git/core/subsurface-qt, branch v4.9.4

cleanup: move dive_table from dive.h to divelist.h

2020-05-01T16:42:31Z

This allows us to decouple dive.h and divelist.h, a small step in include disentangling. Signed-off-by: Berthold Stoeger

cleanup: remove Command::inCommand()

2020-04-26T20:54:59Z

This was used by the divelist to check wether a selection change is programmatical or user-initiated. However, since there is only one entry point for programmatical selection changes, this is not needed anymore. Remove it - this removes an inter-module dependency. Signed-off-by: Berthold Stoeger

undo: replot profile if event changed

2020-04-06T22:13:35Z

Add a DiveListNotifer::eventsChanged signal, which is emitted when the events changed. This is very coarse, at it doesn't differentiate between signal addition / editing / deletion. We might want to be finer in the future. Catch the signal in the profile-widget to replot the dive if this is the currently displayed dive. Reuse the cylindersChanged() slot, but rename it to the now more appropriate profileChanged(). Signed-off-by: Berthold Stoeger

undo: add cylinder undo commands by copy & paste

2020-04-06T22:13:34Z

Do a simple copy & paste followed by a simple search & replace to generate cylinder undo commands from weight undo commands. Obviously, this is still missing the necessary code to keep the dive-data consistent after cylinder editing. Signed-off-by: Berthold Stoeger

cleanup: fix unitialized value

2020-03-24T23:45:48Z

Fixes CID 355179 Signed-off-by: Dirk Hohndel

Undo: implement invalidate-dive command

2020-03-20T22:20:44Z

Connect command to context menu. Signed-off-by: Berthold Stoeger

cleanup: remove current_dive parameter from divesSelected signal

2020-03-12T14:09:01Z

The diveListNotifier.divesSelected() signal is used to inform the models of a selection change. It sent the current dive as a second parameter. This is redundant, because the only sender of the signal sets current_dive just before sending the signal. Remove the parameter, which appears to be an artifact. Signed-off-by: Berthold Stoeger

Cleanup: lower-case filenames in core/subsurface-qt/

2020-02-04T01:16:46Z

We tend to use lower-case filenames. Let's do it for these files as well. Simple search & replace. Signed-off-by: Berthold Stoeger

Undo: make weight editing undoable

2019-12-05T18:14:25Z

Implement the EditWeight undo command. Since there is common code (storage of the old weight), this creates a common base class for RemoveWeight and EditWeight. The model calls directly into the undo command, which is somewhat unfortunate as it feels like a layering violation. It's the easy thing to do for now. Signed-off-by: Berthold Stoeger

Undo: make adding of weights an undoable action

2019-12-05T18:14:25Z

Introduce an AddWeight undo command. This is modelled after the numerous dive-edit undo commands. The redo and undo actions are connected to the WeightModel via two new signals, weightAdded and weightRemoved. Signed-off-by: Berthold Stoeger