subsurface.git/core, branch master

Don't access gasmix.o2.fraction

2021-10-01T15:50:36Z

Air is a special gas that does not contain oxygen according to gasmix.o2.fraction. If you want to use the fo2, you need to use get_o2() to treat this special case correctly. This fixes a bug when setting the MND of a gas containing 21% oxygen when o2 is considered not narcotic. Reported-by: Christoph Gruen Signed-off-by: Robert C. Helling

core: don't write pressure samples with "no sensor"

2021-09-22T16:11:00Z

This has led to broken XML files, don't do it. Signed-off-by: Berthold Stoeger

core: properly clear pressure data of invalid sensors

2021-09-22T16:11:00Z

When we found an invalid sensor (referring to a non existing cylinder) in fixup_dive() the sensor-id was set to NO_SENSOR. This led to invalid XML files, because the code decides to switch into legacy mode. However, there are two pressure readings, which is invalid in legacy mode. Therefore, also clear the pressure data. Signed-off-by: Berthold Stoeger

core: remove superfluous arguments

2021-09-20T21:49:57Z

Fixes CID 373231 Signed-off-by: Dirk Hohndel

Re-do the libdivecomputer fingerprint save/load code

2021-09-19T23:51:46Z

This tries to make our fingerprinting code work better, by avoiding using the "deviceid" field that has always been unreliable because we've calculated it multiple different ways, and even for the same version of subsurface, it ends up changing in the middle (ie we calculate one value initially, then re-calculate it when we have a proper serial number string). So instead, the fingerprinting code will look up and save the fingerprint file using purely "stable" information that is available early during the download: - the device model name (which is a string with vendor and product name separated by a space) - the DC_EVENT_DEVINFO 32-bit 'serial' number (which is not necessarily a real serial number at all, but hopefully at least a unique number for the particular product) but because the model name is not necessarily a good filename (think slashes and other possibly invalid characters), we hash that model name and use the resulting hex number in the fingerprint file name. This way the fingerprint file is unambiguous at load and save time, and depends purely on libdivecomputer data. But because we also need to verify that we have the actual _dive_ associated with that fingerprint, we also need to save the final deviceid and diveid when saving the fingerprint file, so that when we load it again we can look up the dive and verify that we have it before we use the fingerprint data. To do that, the fingerprint file itself contains not just the fingerprint data from libdivecomputer, but the last 8 bytes of the file are the (subsurface) deviceid and the diveid of the dive that is associated with the fingerprint. Signed-off-by: Linus Torvalds

core: remove location service preferences

2021-09-13T18:21:34Z

Including the related tests. Signed-off-by: Dirk Hohndel

mobile: remove GpsLocation

2021-09-13T18:21:34Z

Only used in context of acquiring GPS locations with the mobile app, which we no longer do. Keep the DiveAndLocation structure around as that's needed by the ApplyGpsFixes command. Signed-off-by: Dirk Hohndel

mobile: remove GpsListModel

2021-09-13T18:21:34Z

This is only needed to show the list of GPS fixes obtained with the now removed location service. Signed-off-by: Dirk Hohndel

core: fix off-by-one causing incorrect profile display

2021-09-06T20:00:37Z

In commit 4724c88 get_plot_details_new was updated to pass an index instead of the entry into plot_string. This means we are passing "i" to plot_string after the final increment of the for loop, instead of getting the entry[i] within the loop before the final increment. This means if we are mousing over the far right of the graph, where the time based break is not hit, we will end up passing an index equal to nr-2 instead of nr-3, which is intended to shave off the final two rows containing data not useful to the display. There are a handful of ways to fix this. This commit intends to be consistent with stylistic choices made elsewhere in the project. Signed-off-by: Josh Torres Signed-off-by: Dirk Hohndel

core: add a function to test for sensors of a given cylinder

2021-09-03T20:35:28Z

We want to prevent the user from accidentally deleting a cylinder with sensor readings. Therefore, we need such a function. Signed-off-by: Berthold Stoeger