subsurface.git/core, branch v4.7.1

Silence random warnings

2017-10-20T21:25:18Z

None of these seem to point to actual issues, so let's quiet them. Signed-off-by: Dirk Hohndel

Do not overwrite start and end pressures on cylinder

2017-10-20T13:16:11Z

The pressure information of cylinder should be kept intact when copy-pasting other cylinder related information from other dive. According to Dirk, the gas mix is wanted to be changed as technical divers might have always the same multiple cylinders and wish to copy the gasmix information over. Fixes #689 Signed-off-by: Miika Turkia

Don't show localization warning unless verbose

2017-10-20T10:51:51Z

Signed-off-by: Dirk Hohndel

dive.h: add handling of NULL in get_dive_dc()

2017-10-20T02:03:51Z

This line: dc = &dive->dc can SIGSEGV for a NULL 'dive' pointer. return NULL if 'dive' is NULL. Also handle NULL 'dc' in get_gasmix() and set 'ev' to NULL. Signed-off-by: Lubomir I. Ivanov

Use displayed_dc instead of current_dc

2017-10-19T18:57:02Z

current_dc is a macro that determines the dive computer based on the current dive number. When the planner is started from an emtpy dive list, the dive number ends up being -1 and that doesn't produce a valid dive computer. Use the divecomputer of the displayed_dive instead. This is done via a macro that can also be used in two other places. Without this patch, the planner crashed when called on an empty dive list. Signed-off-by: Robert C. Helling

CNS calculation fix

2017-10-18T21:19:13Z

Identify previous dives for CNS calculation in a similar way as it is done for previous dives for deco calculation. This is done to identify the previous dives dynamically when moving around date/time of a dive in the planner. Signed-off-by: Stefan Fuchs

init_deco correctly identify previous dives and report overlapping dives

2017-10-18T21:19:13Z

When changing the date/time of a dive in the planner the dive may end up in a totaly new position in respect to date/time of other dives in dive list table. It can be moved to the past or the future before or after other existing dives. It also could overlap with an existing dive. This change enables identification of a new "virtual" dive list position and based on this starts looking for previous dives. Then it (as before the change) does init the deco calculation with any applicable previous dive and surface interval. If some of these applicable dives overlap it returns a neg. surface time which is then used in the planner notes to prohibit display of results. Signed-off-by: Stefan Fuchs

plannernotes.c coding style fixes

2017-10-18T15:41:42Z

Signed-off-by: Stefan Fuchs

Minimum gas calculation: Change text colors for delta value output...

2017-10-18T15:41:42Z

and adapt the strings for translation to s.th. which can be handled more easily. Signed-off-by: Stefan Fuchs

Taxonomy: Don't access empty entries when printing the tags

2017-10-17T10:12:07Z

Signed-off-by: Stefan Fuchs