subsurface.git/core, branch v4.8.3

Parser: parse text-based files into arbitrary table

2018-09-28T22:06:00Z

In d815e0c9476ef62e6b84fb28ce48ab7cddefe77e a dive_table pointer was added to the parsing functions to allow parsing into tables other than the global dive table. This will be necessary for undo of import and implementation a cleaner interface. A few cases, notably CSV and proprietary formats were forgotten. Implement parsing into arbitrary tables also for these cases. Signed-off-by: Berthold Stoeger

Cleanup: remove redundant prototypes from dive.h

2018-09-28T14:47:39Z

A few of these prototypes were already in import-csv.h. Put them in an 'extern "C" { ... }' block. Signed-off-by: Berthold Stoeger

Cleanup: Make add_sample_data() local to translation unit

2018-09-28T14:47:39Z

This function in parse_csv.c was not used anywhere. Make it of static linkage. Signed-off-by: Berthold Stoeger

qt-ble: allow reading of partial packet data

2018-09-26T19:13:20Z

The existing BLE dive computers treat BLE as the packetized protocol it is, and read whole packets at a time. However, the Mares BlueLink backend treats it as just a basic "serial over BLE" transport, and for historical reasons reads the reply packets in smaller chunks. This allows that kind of IO behavior, where if the divecomputer backend reads just a part of a packet, we'll split the packet, return the part the user asked for, and push back the leftover packet onto the received packet queue. Signed-off-by: Linus Torvalds

Allow XML sample times to have hh:mm:sec format

2018-09-26T19:13:20Z

We traditionally only allow samples to have a time format of 'mm:ss', so if you have a dive over an hour, you would just have a minutes field larger than 60 minutes. But Matthew Critchley is trying to import some dives from his VMS Redbare CCR, and the sample timestamp format he has is of the type 'hh:mm:ss'. That could be fixed by a xslt translation, but there's no real reason why we couldn't just support that format too. Reported-by: Matthew Critchley Signed-off-by: Linus Torvalds

qt-ble: add BLE packet debugging code

2018-09-25T23:41:13Z

This is perhaps overly verbose, but the timing details helped figure out some EON Core download issues, and it's nice to see when things actually happen. It's also good to see when the data actually enters our queues, and when we read and write the packets. That might help debug the issues Fabio is seeing with the Mares Bluelink. Signed-off-by: Linus Torvalds

qt-ble: only connect the signals to the preferred service

2018-09-25T23:41:13Z

We used to just find all services and connect the characteristics change signal etc to them all, but we really only care about the actual preferred service that we'll be using. So move the qt ble signal connection to after we've selected the preferred service that we will actually be enabling notifications on and do the writes to. Signed-off-by: Linus Torvalds

Metadata: rudimentary support for XMP metadataa in MP4-based videos

2018-09-25T21:59:14Z

XMP is a media-metadata standard based on XML which may be used across a variety of media formats. Some video-processing software writes XMP data without updating the native metadata fields. Therefore, we should aim at reading XMP metadata and give priority of XMP data over native fields. Pros: - Support for *all* common media formats. Cons: - XML (complex, verbose, chaotic). - Does not even come close to fulfilling its promise of being well defined (see below). Implement a simple XMP-parser using libxml2. Connect the XMP-parser to the existing Quicktime/MP4 parser. First problem encountered: According to the spec, XMP data supposed to be put in the 'XMP_' atom. But for example exiftools instead writes an 'uuid' atom with a special 16-byte uid. Implement both, more options will probably follow. Second problem: two versions of recording the creation date were found 1) The content of a tag. 2) The xmp::CreateDate attribute of a tag. Here too, more versions are expected to surface and will have to be supported in due course (with an obvious priority problem). Signed-off-by: Berthold Stoeger

cleanup: do not compare doubles like this

2018-09-25T14:01:39Z

Cleanup another possibly dangerous compare of doubles. Signed-off-by: Jan Mulder

qPref: don't compare doubles for equality

2018-09-25T13:58:17Z

This is a much safer way to do this. Signed-off-by: Dirk Hohndel