subsurface.git/core, branch v4.9.0

Bluetooth: recognize Ratio iX3m GPS dive computers

2019-07-15T18:18:32Z

We cannot tell them apart by Bluetooth name, so pick one of the names. Signed-off-by: Dirk Hohndel

Fix up XML saving of remaining bottom time data

2019-07-14T20:17:13Z

While testing the cylinder type saving fix, I noticed that the RBT saving was broken. Instead of saving RBT whenever it changed, we'd save it when it was non-zero. Which doesn't match the git save format, and also doesn't match what we do when loading an xml file (where we default to the previous RBT value, and a sample RBT will modify it). Signed-off-by: Linus Torvalds

Fix cylinder gas type saving when we have bogus gas use data

2019-07-14T20:17:13Z

Steve Williams reported a crash when saving a previously loaded dive as xml, and gave a gdb backtrace. It turns out that if we can't parse the cylinder use type (OC, diluent, oxygen, unused) we initialize the cylinder use to an invalid type, and then when we save it, we mess up. Fix it up by doing proper limit checking before accessing the "cylinderuse_text[]" array when saving. Reported-by: Steve Signed-off-by: Linus Torvalds

Thumbnailer: improve error message

2019-07-10T15:24:23Z

In the error messages shown when failing to start ffmpeg, instruct the user to set the correct executable in the preferences. Signed-off-by: Berthold Stoeger

Git: handle excess of cylinders or weightsystems gracefully

2019-07-10T02:11:47Z

Currently, the git parser happily trashes memory if a git repository contains too many weightsystems or cylinders. This should only happen in testing, but nevertheless try to handle it gracefully and ignore excess cylinders / weightsystems. Signed-off-by: Berthold Stoeger

Cleanup: call calculate_max_limits_new() in create_plot_info_new()

2019-07-06T18:23:35Z

All callers of create_plot_info_new() called calculate_max_limits_new() a line before. Thus, simply call the latter in the former. This allows us to automatically free the plot data in create_plot_info_new(). The old code overwrote the corresponding field with NULL. As a side-effect, this removes a bogus static variable. Signed-off-by: Berthold Stoeger

Cleanup: fix memory management of the plot data

2019-07-06T18:23:35Z

There was a global variable last_pi_entry_new, which stored the recently allocated plot data. This was freed when new plot data was generated. A very scary proposition: You can never have two plot datas at the same time! But exactly that happens when you export for example subtitles. The only reason why this didn't lead to very crazy behavior is that at least on my Linux machine, the calloc() call would just return the previously freed memory. Fix this mess by removing the global variable and freeing the data in the callers. Signed-off-by: Berthold Stoeger

Cleanup: remove unused get_screen_dpi() function

2019-07-06T11:10:14Z

Signed-off-by: Berthold Stoeger

Cleanup: remove unused declarations from display.h

2019-07-06T11:10:14Z

A number of declarations were not used anywhere. Remove them. Signed-off-by: Berthold Stoeger

Planner: Wait minimum switch time when bailing out to OC

2019-06-28T13:58:52Z

Bailing out does not happen instantly. Rather wait for the minimum stop switch duration before ascending. Signed-off-by: Robert C. Helling