subsurface.git/core, branch v4.9.1

Core: split copy_cylinders() in two functions

2019-07-27T18:55:05Z

copy_cylinders() copied the cylinders of one dive onto another dive and then reset to the original gas values. Presumably, when copy and pasting cylinders from one dive to another, only the types should be copied, not the gases. Moreover, the function could either copy all or only the used cylinders. Firstly, the code was bogus: when restoring the pressures the indices were mixed up: the old indices were used. Thus, when there where uncopied cylinders, not all pressure values were restored. Secondly, it is not clear that all callers actually want to restore the pressure data. It rather appears the two (out of three) callers actually just want to copy the cylinders. Therefore, split the function in 1) copy_cylinders(): copy the cylinders with pressure data 2) copy_cylinder_types(): copy only the cylinder information Since there is only one caller of copy_cylinder_types(), the "used_only" argument can be removed. Since all cylinders are copied there is no point in storing the pressure data. Don't overwrite it in the first place. The resulting two functions should be distinctly easier to understand. Signed-off-by: Berthold Stoeger

Bluetooth: autodetect Shearwater NERD models

2019-07-20T04:50:36Z

This should allow it to work with Subsurface-mobile as well. Fixes #2187 Signed-off-by: Dirk Hohndel

Cleanup: remove bogus mark_divelist_changed() calls

2019-07-20T04:44:13Z

The parsers / downloaders parse into a separate table and do not directly change the divelist. Therefore, they shouldn't call mark_divelist_changed(). Likewise split_dive_at() doesn't modify the dive list and therefore shouldn't call this function. Calling the function has the unwanted side-effect that undoing the change will not clear the *-symbol in the title of the main window. Signed-off-by: Berthold Stoeger

Cleanup: remove unused weightsystem_none() function

2019-07-18T13:01:07Z

This function was used to count the number of weightsystems used in a dive. Since the weightsysems are now collected in a dynamic table it became unused. Remove. Signed-off-by: Berthold Stoeger

Core: dynamically resize weight table

2019-07-18T13:01:07Z

Replace the fixed-size weightsystem table by a dynamically relocated table. Reuse the table-macros used in other parts of the code. The table stores weightsystem entries, not pointers to weightsystems. Thus, ownership of the description string is taken when adding a weightsystem. An extra function adds a cloned weightsystem at the end of the table. Signed-off-by: Berthold Stoeger

Core: Implement same_weightsystem() function to compare weights

2019-07-18T13:00:58Z

This will be used later when joining and editing dives. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

Cleanup: declare functions in profile.h as extern

2019-07-18T12:50:22Z

We seem to do this in other C-headers, so for consistency also do it here. Signed-off-by: Berthold Stoeger

Cleanup: make the plot-pressure type an enum

2019-07-18T12:50:22Z

Sadly, this doesn't give any type safety. But at least it documents the function arguments. Make the last item in the enum as a number-of-pressure-entries sentinel. Use that to size the pressure-values array. Signed-off-by: Berthold Stoeger

Cleanup: introduce function to set pressure values

2019-07-18T12:50:22Z

Instead of assigning the the lvalue of the SENSOR_PRESSURE macro, introduce a general function to set pressure values. Signed-off-by: Berthold Stoeger

Cleanup: update comment in core/gaspressures.c

2019-07-18T12:50:22Z

The comment to populate_pressure_information() was mentioning gas pressures that didn't exist. Remove these parts. Signed-off-by: Berthold Stoeger