subsurface.git/core, branch v4.9.10

android: find the translations

2020-11-23T16:30:57Z

As we switched to the qmake based build we now bundle the translations via the Qt resource system instead of explicitly as Android assets. This adjusts the code that opens the translations accordingly. Signed-off-by: Dirk Hohndel

core/picture: don't compile all on mobile

2020-11-20T01:18:33Z

We don't support adding pictures and videos on mobile, so let's not referernce the infrastrutcture that's needed for that. Signed-off-by: Dirk Hohndel

core: fix incorrect QString::asprintf/vasprintf usage

2020-11-17T20:56:40Z

These are static functions, they cannot be used as a method on an object to construct that object. commit aa5f2e7c73 ("cleanup: replace deprecated sprintf()/vsprintf() calls") introduced this bug in an ill-advised attempt to deal with a deprecation warning. This caused us to not print GPS coordinates in the UI. Signed-off-by: Dirk Hohndel

undo: add a general dives-imported signal

2020-11-14T18:01:50Z

Add a general dives-imported signal for those cases where we want to fully rebuild models, notably, the completion models. The divesAdded signals are too fine, because they are sent per trip and we don't want to reload these models multiple times per import. Signed-off-by: Berthold Stoeger

Gracefully handle infinite MND for oxygen

2020-11-13T19:10:48Z

When breathing pure oxygen and considering it not narcotic, there is not maximal narcotic depth and the formula divides by zero. So better, handle this case separately. Fixes #3080 Signed-off-by: Robert C. Helling

filter: avoid Windows crash

2020-11-12T15:46:52Z

The scope confusion between s (the for loop variable) and s (the function argument) caused a crash in the s.split() on Windows. Signed-off-by: Dirk Hohndel

core: don't construct std::string from null in device.cpp

2020-11-04T23:53:15Z

Recently the QStrings were replaced by std::strings in device.cpp so that they can be accessed from C-code. However, libstd being modelled after C, constructing a std::string from a NULL pointer leads to a crash. Fix one case where this was overlooked. Moreover, replace a null-pointer check by empty_string(), to treat NULL and "" equally. Reported-by: Salvador Cuñat Signed-off-by: Berthold Stoeger

revert preference settings for title color

2020-11-04T22:51:55Z

Because of subsequent changes there is no clean way to just revert the changes introduced in commit 8b36cf1051 ("desktop: offer different colors for info tab titles"), so this manually removes the parts we don't need anymore. This also restores a tooltip value that was inadvertantly removed in that commit. Signed-off-by: Dirk Hohndel

cleanup: random small whitespace cleanup

2020-11-04T07:08:39Z

Signed-off-by: Dirk Hohndel

desktop: offer different colors for info tab titles

2020-11-04T07:08:39Z

Add a preference option to set the color of the text on the information tab to either MediumBlue, LightBlue or Black. The last two of these colors are meant to enable areadable font contrast on displays with dark mode. The choice is saved with the other preferences. [Dirk Hohndel: this isn't really about dark mode, so changed many of the types and variable names, changed the user visible texts, and addressed some whitespace issues] Signed-off-by: willemferguson Signed-off-by: Dirk Hohndel