subsurface.git/core, branch v4.9.4

cleanup: remove unused function append_dive()

2020-05-02T12:52:51Z

Signed-off-by: Berthold Stoeger

cleanup: move declaration of utc_mk* functions to new subsurface-time.h header

2020-05-01T16:42:31Z

No point in slurping in all of dive.h for translation units that only want to do some time manipulation without ever touching a dive. Don't call the header "time.h", because we don't want to end up in a confusion with the system header of the same name. Signed-off-by: Berthold Stoeger

cleanup: only include QString in desktop-widgets/importgps.h

2020-05-01T16:42:31Z

This included QFile, which is fatter and not needed here. Include QFile only in the actual translation unit. Signed-off-by: Berthold Stoeger

cleanup: move dive_table from dive.h to divelist.h

2020-05-01T16:42:31Z

This allows us to decouple dive.h and divelist.h, a small step in include disentangling. Signed-off-by: Berthold Stoeger

cleanup: move FRACTION macro from dive.h to units.h

2020-05-01T16:42:31Z

There appears to be no reason to slurp in all dive.h when compiling membuffer.c. units.h might not seem like the perfect place, but it is the most fitting I found. Signed-off-by: Berthold Stoeger

cleanup: move DECOTIMESTEP from dive.h to planner.h

2020-05-01T16:42:31Z

Long-term project: reduce the size of dive.h Signed-off-by: Berthold Stoeger

cleanup: make enumerate_devices of external linkage

2020-05-01T15:53:45Z

For consistency: declare enumerate_dives as extern, since we do that for all other C-functions. Signed-off-by: Berthold Stoeger

cleanup: make analyze_plot_info local to profile.c

2020-05-01T15:53:45Z

No external caller of this function exists. Moreover, turn the return type to void, as it only returned the passed-in plot_info and no caller used that. Signed-off-by: Berthold Stoeger

cleanup: const-ify a few functions in planner.c

2020-05-01T15:53:45Z

It make debugging much easier if the function signature tells you that a parameter is not altered. Signed-off-by: Berthold Stoeger

profile: for maxtime calculation include the sample after the last event

2020-05-01T10:36:28Z

When plotting profiles with surface segments, there were strange artifacts. As we found out with Robert, these were due to the fact that the calculated maxtime was set to the last event which is just one second inside the surface segment. This terribly confused the profile code. For example, it didn't properly allocate samples for the surface segment. Thus, when calculating maxtime, consider the last sample beyond the last event. Signed-off-by: Berthold Stoeger