subsurface.git/core, branch v4.9.5

cleanup: make local functions of static linkage

2020-05-29T16:20:17Z

A few functions in save-html.c were local but not marked as static. Signed-off-by: Berthold Stoeger

Print correct template name on CSV export

2020-05-26T18:33:10Z

Signed-off-by: Miika Turkia

cleanup: constify time_during_dive_with_offset() function

2020-05-22T21:40:49Z

There is no reason to pass a non-const dive pointer as first argument. Signed-off-by: Berthold Stoeger

cleanup: remove unused function get_dive_n_near()

2020-05-22T21:40:49Z

The last caller was removed in 7eb422d98837b3cfb289a66fa0f3a8f78f222001. Since this is the only caller of dive_within_time_range(), remove that function as well. Signed-off-by: Berthold Stoeger

cleanup: create common QDateTime -> timestamp conversion function

2020-05-22T19:31:06Z

In analogy to the timestamp -> QDateTime conversion, create a common function. 1) For symmetry with the opposite conversion. 2) To remove numerous inconsistencies. 3) To remove use of the deprecated QDateTime::toTime_t() function. Signed-off-by: Berthold Stoeger

cleanup: remove unused libc-structures from get_trip_date_string()

2020-05-22T19:31:06Z

This must be an artifact from before using Qt's datetime functions. Signed-off-by: Berthold Stoeger

cleanup: move timestampToDateTime() to qthelper.cpp

2020-05-22T19:31:06Z

Move this function from maintab.cpp to qthelper.cpp. Since the functionality was used in numerous places, use the helper function there as well. This removes a number of inconsistencies. For example, sometime setTimeSpec(Qt::UTC) was called, even though the QDateTime object was already created with that time spec. Signed-off-by: Berthold Stoeger

Fix incorrect Farenheit to Kelvin formula.

2020-05-22T17:19:58Z

Use defined function instead. Signed-off-by: Paul Buxton

cleanup: set long and short date formats in independent branches

2020-05-22T17:00:43Z

The short and long date formats where initialized in a common if-branch. However, inside the if-branch the code rechecked which of the two should be initialized. This could make sense if there was some common code between the two, but there wasn't. Therefore, make this two independent branches to avoid one nesting-level. Signed-off-by: Berthold Stoeger

BLE: trivial updates to the GATT services lists

2020-05-17T20:52:24Z

Add a couple of known services (Scubapro G2 and Shearwater), and update the names of others that turn out to be used for multiple dive computers. Also add another Broadcom upgrade service UUID. While at it, sort the services numerically to make it easier to see that a UUID already exists, since these service numbers do get used across multiple different devices. Signed-off-by: Linus Torvalds