subsurface.git/core, branch v4.9.6

core: fix compile issue with older g++

2020-06-18T16:05:13Z

Having the full list of all members in the exact order should be enough to get g++ to accept the named initializers. Signed-off-by: Dirk Hohndel

core: fix libdivecomputer dc_custom callbacks structures

2020-06-18T16:05:13Z

The last time those changed, we forgot to update serial_ftdi. In that change set_latency had been removed from libdivecomputer and poll and ioctl had been added. This caused the callbacks to no longer be aligned correctly and the functions were called with the wrong arguments through the wrong function pointers, leading to crashes. Instead of the fragile assumptions about order and type of function pointers, use named initializers. And while we are at it, fix that for the bluetooth implementation as well. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel

cleanup: remove indirection when passing arguments to parser functions

2020-06-16T15:20:53Z

For unknown reasons, the dive site and trip to be parsed into were passed as pointers to pointers. A simple pointer seems to be enough, since the object is not allocated by the function. Signed-off-by: Berthold Stoeger

git-storage: add global flag to indicate successful cloud sync

2020-06-14T20:35:33Z

This may seem like a bit heavy handed as it adds more global state, but given the number of ways in which attempts to sync with the cloud can fail it seems much more reliable to claim success in the spots where we actually know that we have successfully synced with the remote server. Transporting that information back through the various call chains turned out to be very disruptive and ugly, so I went with global state instead. Whenever we access cloud storage (or any git repo), we always first check if it actually is a git repo by calling is_git_repository() - so this is the perfect spot to initialize the variable to false. And there are only two spots where we either clone the remote repo (create_local_repo()) or update the remote with the (potentially merged) local changes (check_remote_status()). So those are the two places where we set the variable to true. Signed-off-by: Dirk Hohndel

git storage: significantly expand logging to stderr

2020-06-14T20:35:33Z

In many cases we did not log the issues the code ran into to stderr which made remote debugging user problems much harder. This hopefully will help with that. Since I was looking at the code, I also made the existing messages more consistent. Signed-off-by: Dirk Hohndel

download: don't warn on unknown gasmixes

2020-06-13T22:55:35Z

Apparently libdivecomputer can return DC_GASMIX_UNKNOWN when fetching tank info with dc_parser_get_field(parser, DC_FIELD_TANK, i, &tank); This caused emission of a warning, which was annoying users. Disable the warning in that case. Fixes #2866 Signed-off-by: Berthold Stoeger

cleanup: make local functions of static linkage

2020-05-29T16:20:17Z

A few functions in save-html.c were local but not marked as static. Signed-off-by: Berthold Stoeger

Print correct template name on CSV export

2020-05-26T18:33:10Z

Signed-off-by: Miika Turkia

cleanup: constify time_during_dive_with_offset() function

2020-05-22T21:40:49Z

There is no reason to pass a non-const dive pointer as first argument. Signed-off-by: Berthold Stoeger

cleanup: remove unused function get_dive_n_near()

2020-05-22T21:40:49Z

The last caller was removed in 7eb422d98837b3cfb289a66fa0f3a8f78f222001. Since this is the only caller of dive_within_time_range(), remove that function as well. Signed-off-by: Berthold Stoeger