subsurface.git/core, branch v4.9.8

core: don't construct std::string from null in device.cpp

2020-11-04T23:53:15Z

Recently the QStrings were replaced by std::strings in device.cpp so that they can be accessed from C-code. However, libstd being modelled after C, constructing a std::string from a NULL pointer leads to a crash. Fix one case where this was overlooked. Moreover, replace a null-pointer check by empty_string(), to treat NULL and "" equally. Reported-by: Salvador Cuñat Signed-off-by: Berthold Stoeger

revert preference settings for title color

2020-11-04T22:51:55Z

Because of subsequent changes there is no clean way to just revert the changes introduced in commit 8b36cf1051 ("desktop: offer different colors for info tab titles"), so this manually removes the parts we don't need anymore. This also restores a tooltip value that was inadvertantly removed in that commit. Signed-off-by: Dirk Hohndel

cleanup: random small whitespace cleanup

2020-11-04T07:08:39Z

Signed-off-by: Dirk Hohndel

desktop: offer different colors for info tab titles

2020-11-04T07:08:39Z

Add a preference option to set the color of the text on the information tab to either MediumBlue, LightBlue or Black. The last two of these colors are meant to enable areadable font contrast on displays with dark mode. The choice is saved with the other preferences. [Dirk Hohndel: this isn't really about dark mode, so changed many of the types and variable names, changed the user visible texts, and addressed some whitespace issues] Signed-off-by: willemferguson Signed-off-by: Dirk Hohndel

parser: don't crash when parsing tags

2020-11-01T18:59:39Z

When encountering a tag, we would parse into the last weightsystem. However, we only create weightsystems when encountering tag. Therefore, this code would either crash or overwrite the previous weightsystem. Instead, create a new weightsystem for each tag. Moreover, make sure that inside a tag a weightsystem actually exists. This should be the case, but who knows...? Reported-by: Nihal Gabr Signed-off-by: Berthold Stoeger

core: on import remove merged dives from trip/divesite

2020-11-01T06:20:59Z

When dives were merged on import, they were not unregistered from their dive site and trip before being deleted. Thus, these tables had stale pointers, which would ultimate lead to crashes. Signed-off-by: Berthold Stoeger

cleanup: refactor subsurfacesysinfo.cpp

2020-10-27T23:18:09Z

This used to be a copy of QSysInfo. However, once the requirement was raised to Qt5.4, this was replaced by a subclass of the original QSysInfo - which made the whole file mostly obsolete. Just use QSysInfo directly where needed. Only for windows.c, which can't call directly into Qt, keep the isWin7Or8() helper function. Signed-off-by: Berthold Stoeger

cleanup: move variable declaration closer to use

2020-10-27T02:27:03Z

This way we avoid an unused variable warning on mobile builds. Signed-off-by: Dirk Hohndel

cleanup: remove unused function argument

2020-10-27T02:27:03Z

Also, only compile the static function where it is used. Signed-off-by: Dirk Hohndel

cleanup: SkipEmptyParts syntax has changed

2020-10-27T02:27:03Z

Sadly, the new enum has only been available since Qt 5.14, so this is a rather ugly replacement. Signed-off-by: Dirk Hohndel