subsurface.git/desktop-widgets/plugins, branch v4.8.2

desktop-widgets/facebook: remove SettingsObjectWrapper

2018-08-15T23:11:39Z

remove use of SettingsObjectWrapper:: remove include of SettingsObjectWrapper.h use qPrefFoo:: for setters and getters replace prefs.foo with qPrefXYZ::foo() where feasible (this expands to the same code, but gives us more control over the variable). Signed-off-by: Jan Iversen

Cleanup: remove all override modifiers

2018-08-01T13:30:00Z

Commit df156a56c08a56eb380711a507ef739d8150a71f replaced "virtual" by "override" where appropriate. Unfortunately, this had the unintended consequence of producing numerous clang warnings. If clang finds a override-modified function in a class definition, it warns for *all* overriden virtual functions without the override modifier. To solve this, go the easy route and remove all overrides. At least it is consistent. Signed-off-by: Berthold Stoeger

Cleanup: replace virtual by override where appropriate

2018-07-31T09:02:34Z

The keyword "virtual" signalizes that the function is virtual, i.e. the function of the derived class is called, even if the call is on the parent class. It is not necessary to repeat the "virtual" keyword in derived classes. To highlight derived virtual functions, the keyword "override" should be used instead. It results in a hard compile- error, if no function is overridden, thus avoiding subtle bugs. Replace "virtual" by "override" where appropriate. Moreover, replace Q_DECL_OVERRIDE by override, since we require reasonably recent compilers anyway. Likewise, replace /* reimp */ by "override" for consistency and compiler support. Signed-off-by: Berthold Stoeger

core: activate qPrefFacebook

2018-07-27T19:36:20Z

remove Facebook from SettingsObjectWrapper and reference qPrefFacebook update files using SettingsObjectWrapper/Facebook to use qPrefFacebook this activated qPrefFacebook and removed the similar class from SettingsObjectWrapper. Signed-off-by: Jan Iversen

Cleanup: fold core/helpers.h into core/qthelper.h

2018-06-04T15:50:10Z

helpers.h included qthelper.h and all functions declared in helpers.h were defined in qthelper.h. Therefore fold the former into the latter, since the split seems completely arbitrary. While doing so, change the return-type of get_dc_nichname from "const QString" to "QString". Signed-off-by: Berthold Stoeger

desktop-widgets/.../facebook: Change Q_UNUSED to no parameter name

2018-05-21T19:48:04Z

C++ permits use of parameters without name, which signals unused Signed-off-by: Jan Iversen

Cleanup: consistently use toUtf8() instead of toLocal8Bit()

2018-03-14T11:55:36Z

These do the same, since the text-codex is set to UTF-8 on startup. Signed-off-by: Berthold Stoeger

cleanup: remove unused private variable

2017-12-29T17:14:20Z

CID 208307 Signed-off-by: Jan Mulder

Use icons relative path.

2017-12-01T07:14:46Z

Icon paths are defined in one place only - application's embedded resources. Signed-off-by: Martin Měřinský

Revert "Use icons relative path."

2017-11-29T22:05:07Z

This reverts commit b0d98f6e269be9560de1b9c140855c85fecf1dd1.