subsurface.git/desktop-widgets/preferences, branch v4.7.5

Use better aliases for icons.

2017-12-01T07:14:46Z

Icon aliases were complete mess. Some icons had alias some didn't. Named with underscores vs. hyphens vs. camelCase. Lower vs. upper case. "ICON" prefix vs. suffix vs. nothing. With vs. without filename suffix. Some didn't make sence. Eg. mapwidget-marker-gray (I can see, it's grey, but what does it represent?) Some were duplicated, eg warning vs. warning-icon. Some were name after widget, which is wrong. Do not reinvent wheel. Use widely used naming scheme close to Freedesktop Icon Naming Specification. This will enable usage of common icons from current set in the future. Thus Subsurface will fit nicely to GUI. This changes icon aliases to one, easy grep-able style. Signed-off-by: Martin Měřinský

Use icons relative path.

2017-12-01T07:14:46Z

Icon paths are defined in one place only - application's embedded resources. Signed-off-by: Martin Měřinský

Revert "Use icons relative path."

2017-11-29T22:05:07Z

This reverts commit b0d98f6e269be9560de1b9c140855c85fecf1dd1.

Revert "Use consistent aliases for all icons."

2017-11-29T22:05:07Z

This reverts commit 92e9c6606f6ef3ad16d2e31f9f9a8f5fa14f2c1a.

Use consistent aliases for all icons.

2017-11-29T10:46:35Z

Icon aliases were inconsistent mess. Underscores vs. hyphens vs. camelCase. With vs. without filename suffix. Lower vs. upper case. "icon" suffix vs. prefix vs. nothing. Some were duplicated, eg warning vs. warning-icon. Some icons didn't have alias at all. This changes all icon aliases to one, easy grep-able style which complies to Freedesktop Icon Naming Specification (Guidelines). Signed-off-by: Martin Měřinský

Use icons relative path.

2017-11-29T10:46:35Z

Icon paths are defined in one place only - application's embedded resources. Signed-off-by: Martin Měřinský

Fix ownership issues in preferences code

2017-11-25T15:41:09Z

Each preferences object owns its string members. In three cases, pointers were copied instead of strings, leading to (in the best case) dangling pointers if the user edited values: 1) In the GET_TXT macro in core/prefs-macros.h 2) In the PreferencesDialog::defaultsRequested() method 3) In main() of the mobile version This patch fixes these issues, by using copy_string() or copy_prefs() as appropriate. The only reason that the old code didn't crash regularly is that the default_prefs object was only used at startup and defaultsRequested() is (at the moment?) dead code. This patch also aligns the backslashes in core/pref.h and fixes a typo. The declaration of copy_prefs() is moved to the core/prefs.h header. Signed-off-by: Berthold Stoeger

Fix typo: successfull -> successful and succesfully -> successfully

2017-11-20T09:01:15Z

Signed-off-by: Berthold Stoeger

Planner and profile limit minimum GFlow to 10 and minimum GFhigh to 40

2017-11-13T10:53:55Z

Signed-off-by: Stefan Fuchs

Typo: modp02 -> modpO2

2017-11-12T14:11:30Z

Fixes two function names, where O2 was written as 02. Signed-off-by: Berthold Stoeger