subsurface.git/desktop-widgets/preferences, branch v4.8.4

Fix bug in for loop that can lead to segfault

2018-10-25T22:23:03Z

In case of big log files, where MAX_TANK_INFO is reached, tank_info[i] != NULL should be checked after i

Preferences: set deco parameters correctly enabled

2018-10-19T10:25:32Z

And fix another bug in this area of the code. It appeared that the gflow/gfhigh and conservatism deco parameters where not enabled at startup, but after toggling the VPM vs BUEHLMANN setting they were. So, fix this as well. Signed-off-by: Jan Mulder

Preferences: wire-up the deco parameters

2018-10-19T10:25:32Z

The deco parameters need special treatment to wire them up to the underlying deco model code. And with the new preferences setup this is a lot of boilerplate. Signed-off-by: Jan Mulder

Cleanup: reinstate override modifiers

2018-09-29T22:23:25Z

This reverts commit 1c4a859c8d0b37b2e938209fe9c4d99e9758327a, where the override modifiers were removed owing to the noisy "inconsistent override modifiers" which is default-on in clang. This warning was disabled in 77577f717f5aad38ea8c4c41c10c181486c4337f, so we can reinstate the overrides. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

Desktop/settings: hook up button to clear remembered DCs

2018-09-23T18:49:30Z

And at least admit that the reset settings button isn't hooked up at all. OOOOPS. Signed-off-by: Dirk Hohndel

Desktop/settings: add button to forget remembered dive computers

2018-09-23T18:49:30Z

This isn't hooked up, yet. Signed-off-by: Dirk Hohndel

core/settings ... : remove qPref* includes in qPref.h

2018-09-12T00:25:00Z

reduce number of includes by removing qPref* includes in qPref.h Signed-off-by: Jan Iversen

core: declare cloud_status in qPrefCloudStorage

2018-09-12T00:25:00Z

qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen

prefs: cloud_new_password is not a preference

2018-09-10T23:26:49Z

It's a mamber of the cloud storage authentication class, used to hold the proposed new password until the backend has accepted it. Signed-off-by: Dirk Hohndel

Desktop: Remove webservice, remove UI components (1)

2018-09-10T01:28:08Z

The very first part of the full removal of the GPS webservice. This removes the UI artefacts and a tiny bit fallout. This leaves in place all the background processing. Be very careful here as this can break workflow of users that currently have unapplied GPS coordinates sitting in the webservice, and do upgrade to the version where this commit goes in. They have no clean UI way any more to apply those GPS fixes from the desktop. Signed-off-by: Jan Mulder