subsurface.git/desktop-widgets/preferences, branch v5.0.2

mobile: add GF fields for ceiling calculation

2021-01-19T20:34:46Z

Adds fields to the advanced preferences page to modify GFLow and GFHigh for the Buhlmann decompression model for calculating ceilings. Updated preferences code to set the Buhlmann parameters in core/deco.c when the GF prefs are updated. Signed-off-by: Doug Junkins

cleanup: remove getDivesInTrip() in qthelper.cpp

2020-12-29T16:34:09Z

This function was not used anywhere. Moreover, remove a few unused includes from qthelper.h. Surprisingly, a number of users of qthelper.h depend on these, so readd them at the appropriate places. Signed-off-by: Berthold Stoeger

prefs: add option to display only actually used tanks

2020-12-13T19:49:59Z

A user complained about the default cylinders list. Provide a preferences option to turn this off. When changing the preferences, the tank-info model will be completely rebuilt. Currently, this is a bit crude as this will be done for any preferences change. Suggested-by: Adolph Weidanz Signed-off-by: Berthold Stoeger

core: keep tank infos in a dynamic table

2020-12-13T19:49:59Z

The list of known tank types were kept in a fixed size table. Instead, use a dynamic table with our horrendous table macros. This is more flexible and sensible. While doing this, clean up the TankInfoModel, which was leaking memory. Signed-off-by: Berthold Stoeger

preferences: connect() dialog page only once

2020-12-12T23:52:40Z

Weirdly, the settingsChanged() signal of the dialog-pages was connected() to the settingsChanged() signal of the dialog every time the settings were accepted. Do it only once in the constructor. Signed-off-by: Berthold Stoeger

preferences: don't remove/add pages in refreshPages()

2020-12-12T23:52:40Z

This function was called when opening the preferences dialog to update all the pages with the current preferences. For unknown reasons it also removed / readded all the pages. Remove that code and use the now leaner function when refreshing the pages. Signed-off-by: Berthold Stoeger

preferences: sort pages only once

2020-12-12T23:52:40Z

After each addition of a page in the constructor, the list was resorted. This appears pointless. Instead, sort the list only after all pages were added. Since the add-page function is now a single line, remove it. Signed-off-by: Berthold Stoeger

preferences: create global settingsChanged signal

2020-12-12T23:52:40Z

So far, the PreferencesDialog emitted a settingsChanged signal. This meant that models that listened to that signal had to conditionally compile out the code for mobile or the connection had to be made in MainWindow. Instead, introduce a global signal that does this and move the connects to the listeners to remove inter-dependencies. Signed-off-by: Berthold Stoeger

cleanup: remove unused PreferencesDialog::emitSettingsChanged()

2020-12-12T23:52:40Z

Signed-off-by: Berthold Stoeger

revert preference settings for title color

2020-11-04T22:51:55Z

Because of subsequent changes there is no clean way to just revert the changes introduced in commit 8b36cf1051 ("desktop: offer different colors for info tab titles"), so this manually removes the parts we don't need anymore. This also restores a tooltip value that was inadvertantly removed in that commit. Signed-off-by: Dirk Hohndel