subsurface.git/desktop-widgets/tab-widgets, branch masterforked from https://github.com/subsurface/subsurfacehttps://git.tsegers.com/subsurface.git/atom?h=master2021-10-11T17:53:41Zdesktop: fix div-by-zero when selecting multiple invalid dives2021-10-11T17:53:41ZTim Segerstsegers@pm.me2021-10-11T16:53:52Zurn:sha1:b618d932413b3226faa7f29f719a1cabf2bc5bf9
Signed-off-by: Tim Segers <tsegers@pm.me>
desktop: warn when deleting a cylinder with sensor readings2021-09-03T20:35:28ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-09-02T17:11:35Zurn:sha1:9376721873f9897dcc2a451b5b8e0c56ca82f939
This makes the sensors pointless and in the future, they
will be removed.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Remove the divecomputer naming tab2021-08-18T20:22:02ZLinus Torvaldstorvalds@linux-foundation.org2021-08-17T04:15:54Zurn:sha1:ba6f7361da873609d72ab4ba3b1d55edd8f5569d
The TabDiveComputer model won't work in the new world order, where you
can't even insert a new device entry without a nickname to be edited.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
cleanup: replace membuffer by membufferpp in C-code2021-07-23T18:22:43ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-07-20T05:45:31Zurn:sha1:16b31985c3245d5cb3be26f3cc0aa06bc6acb139
Thus, the membuffer data is automatically freed when going
out of scope - one thing less to worry about.
This fixes one use-after-free bug in uploadDiveLogsDE.cpp
and one extremely questionable practice in divetooltipitem.cpp:
The membuffer was a shared instance across all instances
of the DiveToolTipItem.
Remves unnecessary #include directives in files that didn't
even use membuffer.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
desktop: query DivePlannerPointsModel for planner state2021-04-02T20:53:23ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-02-21T18:10:14Zurn:sha1:ed8ad9ac807624b9fb87076e8a41cc2e47a5b076
MainTab::updateDiveInfo() is not executed when in the planner.
To decide whether the application is in the planner state,
it queried the profile. Instead, query the DivePlannerPointsModel.
Currently, there is no autoritative carrier of that flag.
However, the MainTab has a dependency on DivePlannerPointsModel
anyway, and therefore this removes a dependency on the
profile. This brings us closer to a state where we can have
multiple profiles.
Ultimately, it is hoped that the whole check can be removed
at this place, making the point moot.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
desktop: remove check for editMode in maintab2021-04-02T20:53:23ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-01-29T15:15:17Zurn:sha1:4d60662531b3c4ad1ce17c0fd2d7f9844cf52ece
The accept / reject message is only shown in edit-mode, no
need to check it. This is a step in simplification / removal
of the edit mode.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: display arbitrary dive2021-04-02T20:53:23ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-01-28T13:24:38Zurn:sha1:2789bb05b133a7cf54081d58d4f5c51c8977e951
So far the profile operated on the global displayed_dive. Instead,
take the dive to be displayed as a parameter to the plotDive()
functions.
This is necessary if we want to have multiple concurrent
profile objects. Think for example for printing or for mobile
where multiple dive objects are active at the same time.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: detect dive-mode change in profile2021-02-06T18:00:39ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-01-27T22:41:51Zurn:sha1:0b0e6672d5622238c2fb583dad6b51813b9338b3
The profile must be replotted when the dive mode changes.
Weirdly, this was routed via the dive-information tab
(making it inherently non-mobile compatible). Detect
such a change directly in the profile.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
desktop: don't access profile directly to redraw it2021-02-06T18:00:39ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2021-01-27T17:08:23Zurn:sha1:c584e28f2e0cc97cb2573d66697fdb0c0f160b66
The MainWindow has a function to replot the profile. Use that
instead of accessing the profile directly.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
profile: remove ProfileWidget2::dateTimeChanged()2021-01-10T23:57:39ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2020-12-20T11:00:57Zurn:sha1:78196839903398434638073d26ee9b47da0a0e55
This function sent a signal and the only listener was removed
in the previous commit.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>