subsurface.git/desktop-widgets/tab-widgets, branch v4.7.8

Cleanup: Initialize variable MainTab::lastSelectedDive

2018-03-19T15:54:31Z

This variable was read before being set. Signed-off-by: Berthold Stoeger

Cleanup: introduce copy_qstring() function

2018-03-14T11:55:36Z

strdup(qPrintable(s)) and copy_string(qPrintable(s)) were such common occurrences that they seem worthy of a short helper-function. Signed-off-by: Berthold Stoeger

Cleanup: consistently use qPrintable()

2018-03-14T11:55:36Z

Replace constructs of the kind s.toUtf8().data(), s.toUtf8().constData(), s.toLocal8Bit().data(), s.toLocal8Bit.constData() or qUtf8Printable(s) by qPrintable(s). This is concise, consistent and - in principle - more performant than the .data() versions. Sadly, owing to a suboptimal implementation, qPrintable(s) currently is a pessimization compared to s.toUtf8().data(). A fix is scheduled for new Qt versions: https://codereview.qt-project.org/#/c/221331/ Signed-off-by: Berthold Stoeger

Choose water presets from a qcombobox in planner, custom value possible

2018-03-02T16:38:22Z

Add a combo box for water types with defaults for fresh water, sea water and the EN 13319. All values taken from units.h, where EN 13319 was added beforehand. Custom values can be entered through a spinbox. Also changed "Salinity" in TapDiveInformation.ui to "Water type". Translation required! Signed-off-by: Oliver Schwaneberg

Cleanup: remove two unused macros in tabwidgets/maintab.cpp

2018-02-26T07:53:12Z

Signed-off-by: Berthold Stoeger

Use temperature_t for temperatures in struct stats_t

2018-02-24T19:45:17Z

Use struct temperature_t for temperatures in struct stats_t and use get_temperature_string() when printing these temperatures for statistics and HTML export. Signed-off-by: Stefan Fuchs

Consistently use the famous l for liters in info tab

2018-02-18T03:48:50Z

For salinity in info tab change the l character to the famous Subsurface "ℓ". Signed-off-by: Stefan Fuchs

Do not remove seconds from duration input field

2018-02-04T21:40:02Z

This change deals with issue #554. If you enter a dive duration manually, the cell renderer cuts the seconds away when the changes are saved. I added the helper "render_seconds_to_string" as a counterpart to "parseDurationToSeconds". The helper keeps the seconds, if not null. The rendering of the cell is done at two places in the code, so I think it is cleaner to add a dedicated method for it. Signed-off-by: Oliver Schwaneberg

desktop: clear tags when hitting new logbook

2018-01-01T09:26:13Z

A very simple commit to start 2018. When hitting new logbook from a currently open logbook, and the current dive has tags filled in, they stayed around in the UI. Just clear them. Further, delete an unused variable. Signed-off-by: Jan Mulder

Fix order of initilization list in MainTab constructor.

2017-12-20T23:04:30Z

Besides being the right thing to do (code reflects reality), it silences a compiler warning. Signed-off-by: Berthold Stoeger