Desktop: disable UI elements that make no sense during editing

2018-09-14T08:00:54Z

As described in the referenced issue, we where able to navigate to nonlogical static pages (like information, statistics. extra data) when adding a dive. These are output style pages that make no sense on edit or add. Further, disable access to some pages when entering edit mode. Notice that the small change in file mainwindow.cpp is simply because this this not work at all, and became superfluous any way. Fixes: #1445 Signed-off-by: Jan Mulder

Planner: fix display of "overlapping dives" message

2018-09-12T21:17:55Z

1) Add a missing

2) More importantly: recognize html content via

-tags instead of -tags. Signed-off-by: Berthold Stoeger

Filter: remove diveSiteAdded signal of MainTab

2018-08-31T14:48:23Z

Signals can be useful. In this case, a simple function call does it. Thus, remove the signal. It can be readded later at an more appropriate place. Signed-off-by: Berthold Stoeger

Cleanup: pass gasmix by value

2018-08-23T12:16:38Z

In a previous commit, the get_gasmix_* functions were changed to return by value. For consistency, also pass gasmix by value. Note that on common 64-bit platforms struct gasmix is the size of a pointer [2 * 32 bit vs. 64 bit] and therefore uses the same space on the stack. On 32-bit platforms, the stack use is probably doubled, but in return a dereference is avoided. Supporting arbitrary gas-mixes (H2, Ar, ...) will be such an invasive change that going back to pointers is probably the least of our worries. This commit is a step in const-ifying input parameters (passing by value is the ultimate way of signaling that the input parameter will not be changed [unless there are references to said parameter]). Signed-off-by: Berthold Stoeger

Cleanup: remove all override modifiers

2018-08-01T13:30:00Z

Commit df156a56c08a56eb380711a507ef739d8150a71f replaced "virtual" by "override" where appropriate. Unfortunately, this had the unintended consequence of producing numerous clang warnings. If clang finds a override-modified function in a class definition, it warns for *all* overriden virtual functions without the override modifier. To solve this, go the easy route and remove all overrides. At least it is consistent. Signed-off-by: Berthold Stoeger

Dive media: implement "Open folder of selected media files"

2018-07-20T06:29:27Z

Add a context-menu entry to TabDivePhotos which opens the folder(s) of all selected files. Fixes #1514. Suggested-by: Stefan Fuchs Signed-off-by: Berthold Stoeger

UI change of "images"/"photo" to "media" or "media files"

2018-07-15T16:38:12Z

This changes the above mentioned terms everywhere in the UI to reflect the fact that Subsurface now also supports video files on top of image files. Signed-off-by: Stefan Fuchs

Change from gettextFromC::instance()->tr() to gettextFromC::tr();

2018-06-18T05:42:39Z

Code cleanup. Suggested-by: Berthold Stoeger Signed-off-by: Stefan Fuchs

Use correct "tr" call for translating dive mode names

2018-06-18T05:42:39Z

Correctly use gettextFromC::instance()->tr(); instead of a simple tr(); to translate the dive mode names. This goes on top of 0bc9edf855caf95e2d58ccaf704ceeda079e06f1 and finally makes the whole thing work. Signed-off-by: Stefan Fuchs

Fix an error around translation of dive modes in the UI

2018-06-16T21:36:20Z

This fixes an mistake introduced in 3d1072f8862e4c329dc2678df52a24137b8d4704 Signed-off-by: Stefan Fuchs

subsurface.git/desktop-widgets/tab-widgets, branch v4.8.2