subsurface.git/desktop-widgets/tab-widgets, branch v4.9.0

Desktop: clear notes on empty dive

2019-07-11T13:58:30Z

If no dive is set, all fields except the note field were cleared. Also clear notes. Fixes #2172 Reported-by: Anton Lundin Signed-off-by: Berthold Stoeger

Desktop: enable clearing of dive site

2019-07-04T01:41:09Z

Clearing dive site did not work for two reasons: 1) We didn't get a signal when editing was finished. 2) When clearing the dive site, the "add new dive site" site was set. Thus, connect to the editingFinished signal and in DiveLocationLineEdit::currDiveSite() return a null pointer if the string is empty. This means that it is not possible to have a dive site with an empty string, but that shouldn't be a problem, right? Fixes #2148 Signed-off-by: Berthold Stoeger

Desktop: fix time editing

2019-06-24T08:32:41Z

We were shifting in the wrong direction. Which caused the field to be marked as 'edited' again, which meant we shifted the wrong way and twice the distance. This seems to fix the problem for both date and time editing. Signed-off-by: Dirk Hohndel

Undo: don't send signals batched by trip

2019-06-23T18:08:46Z

Since the default view is batched by trips, signals were sent trip-wise. This seemed like a good idea at first, but when more and more parts used these signals, it became a burden. Therefore push the batching to the part of the code where it is needed: the trip view. The divesAdded and divesDeleted are not yet converted, because these are combined with trip addition/deletion. This should also be detangled, but not now. Since the dive-lists were sorted in the processByTrip function, the dive-list model now does its own sorting. This will have to be audited. Signed-off-by: Berthold Stoeger

Cleanup: remove unnecessary get_gas_used() call

2019-06-19T20:11:10Z

The result was not used anywhere, so why bother? Signed-off-by: Berthold Stoeger

Cleanup: use quotation marks for non-system includes

2019-06-19T20:11:10Z

That's common practice, so lets do it that way. Signed-off-by: Berthold Stoeger

Cleanup: move trip-related functions into own translation unit

2019-06-19T20:11:10Z

These functions were spread out over dive.c and divelist.c. Move them into their own file to make all this a bit less monolithic. Signed-off-by: Berthold Stoeger

Undo: add undo button to multi-dive-edited warning message

2019-06-15T18:20:49Z

Simply connect the button the the undo-action and the hide-message action. Signed-off-by: Berthold Stoeger

Undo: hide multi-dive-edit warning message on subsequent edit

2019-06-15T18:20:49Z

When a different field is edited, hide any old multi-dive-edit warning message. The reason is that we might want to add an "undo" button to the message. But this will undo the wrong command if we don't hide the message. Sadly, this means that we can't use animated show / hide, because an animatedHide() followed immediately by an animatedShow() does not necessarily show the message. In other words, and animatedShow() does not interupt a started animatedHide()!? Signed-off-by: Berthold Stoeger

Undo: show warning message if more than one dive edited

2019-06-15T18:20:49Z

On the MainTab, warn if more than one dive was edited. To this purpose, add a new KMessageWidget with an "OK" button that closes the message. Code is mostly a copy of the already existing "Editing dive" message. Signed-off-by: Berthold Stoeger