subsurface.git/desktop-widgets/tab-widgets, branch v4.9.1

Desktop: fix index in weightsystems_equal()

2019-07-27T18:51:34Z

The weightsystem_equal() function compares weightsystems of two dives to decide whether the "commit changes" message should be shown and to decide which dives are edited when changing multiple dives. Due to an index mixup the function returned wrong results for more than two weightsystems. Fix it. Signed-off-by: Berthold Stoeger

Core: dynamically resize weight table

2019-07-18T13:01:07Z

Replace the fixed-size weightsystem table by a dynamically relocated table. Reuse the table-macros used in other parts of the code. The table stores weightsystem entries, not pointers to weightsystems. Thus, ownership of the description string is taken when adding a weightsystem. An extra function adds a cloned weightsystem at the end of the table. Signed-off-by: Berthold Stoeger

Cleanup: Remove unused function calls in main tab

2019-07-18T12:47:27Z

per_cylinder_mean_depth() and selected_dives_gas_parts() are used in the dive-information and statistics tab, respectively. Nevertheless, these functions are called on the main tab as well and the result is trashed. Therefore remove the calls. Must have been an artifact. Signed-off-by: Berthold Stoeger

Cleanup: remove includes from qthelper.h

2019-07-18T12:42:55Z

To reduce interdependencies, remove the dive.h and divelist.h includes in qthelper.h Signed-off-by: Berthold Stoeger

Desktop: clear notes on empty dive

2019-07-11T13:58:30Z

If no dive is set, all fields except the note field were cleared. Also clear notes. Fixes #2172 Reported-by: Anton Lundin Signed-off-by: Berthold Stoeger

Desktop: enable clearing of dive site

2019-07-04T01:41:09Z

Clearing dive site did not work for two reasons: 1) We didn't get a signal when editing was finished. 2) When clearing the dive site, the "add new dive site" site was set. Thus, connect to the editingFinished signal and in DiveLocationLineEdit::currDiveSite() return a null pointer if the string is empty. This means that it is not possible to have a dive site with an empty string, but that shouldn't be a problem, right? Fixes #2148 Signed-off-by: Berthold Stoeger

Desktop: fix time editing

2019-06-24T08:32:41Z

We were shifting in the wrong direction. Which caused the field to be marked as 'edited' again, which meant we shifted the wrong way and twice the distance. This seems to fix the problem for both date and time editing. Signed-off-by: Dirk Hohndel

Undo: don't send signals batched by trip

2019-06-23T18:08:46Z

Since the default view is batched by trips, signals were sent trip-wise. This seemed like a good idea at first, but when more and more parts used these signals, it became a burden. Therefore push the batching to the part of the code where it is needed: the trip view. The divesAdded and divesDeleted are not yet converted, because these are combined with trip addition/deletion. This should also be detangled, but not now. Since the dive-lists were sorted in the processByTrip function, the dive-list model now does its own sorting. This will have to be audited. Signed-off-by: Berthold Stoeger

Cleanup: remove unnecessary get_gas_used() call

2019-06-19T20:11:10Z

The result was not used anywhere, so why bother? Signed-off-by: Berthold Stoeger

Cleanup: use quotation marks for non-system includes

2019-06-19T20:11:10Z

That's common practice, so lets do it that way. Signed-off-by: Berthold Stoeger