subsurface.git/desktop-widgets/tab-widgets, branch v4.9.7

translations: initialize water type strings at run time

2020-09-21T20:42:00Z

The water type strings were static and therefore passed through gettextFromC::tr() before main(). One would hope to get a warning in such a case, but this is not the case. Therefore, use the QT_TRANSLATE_NOOP macro to register the strings in Qt's translation system and translate the list when needed. Signed-off-by: Berthold Stoeger

cleanup: whitespace fixes in TabDiveInformation

2020-05-25T15:33:08Z

Use C-style function definitions (squirly brackets on new lines) and remove empty lines at end of file. Signed-off-by: Berthold Stoeger

desktop: localize salinity value

2020-05-25T15:33:08Z

The salinity value was not displayed with localized thousands separators. E.g. to a user of a German locale the density read as slightly over 1 g/l, when it should be approximately 1000 g/l. For consistency, also localize that value. Also localize the CNS and OTU numbers, even though these should (hopefully!) never come with thousands separators. Signed-off-by: Berthold Stoeger

cleanup: create common QDateTime -> timestamp conversion function

2020-05-22T19:31:06Z

In analogy to the timestamp -> QDateTime conversion, create a common function. 1) For symmetry with the opposite conversion. 2) To remove numerous inconsistencies. 3) To remove use of the deprecated QDateTime::toTime_t() function. Signed-off-by: Berthold Stoeger

cleanup: move timestampToDateTime() to qthelper.cpp

2020-05-22T19:31:06Z

Move this function from maintab.cpp to qthelper.cpp. Since the functionality was used in numerous places, use the helper function there as well. This removes a number of inconsistencies. For example, sometime setTimeSpec(Qt::UTC) was called, even though the QDateTime object was already created with that time spec. Signed-off-by: Berthold Stoeger

desktop: update date and time fields if user changes format

2020-05-22T17:00:43Z

This was more painful than expected, because we get the "preferences" changed signal too early when the user switches to system format. The correct format is set by the preferences-widget, not the preferences subsystem. Signed-off-by: Berthold Stoeger

desktop: hide/unhide tags if dive site was edited

2020-05-08T15:51:37Z

The tags of the dive site were shown/hidden when changing the current dive. Thus the following could happen: 1) User changes to dive with no tags. Tags are hidden. 2) User add image, which creates GPS tag 3) Tag is updated but not shown. Fix this by showing/hiding tags when they are calculated not when switching the dive. Signed-off-by: Berthold Stoeger

cleanup: free tab-widgets when exiting the application

2020-05-07T15:56:59Z

This is completely irrelevant, however out of principle, let's free the tab-widgets at the end of the application. To do so, use Qt's object hierarchy. I'm not a fan of this kind of memory management, but it is how it is. Moreover, remove the explicit constructor of MainTab, since it doesn't differ from the default constructor anyway. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

cleanup: remove clearing of displayed_dive in MainTab constructor

2020-05-07T15:56:59Z

Clearing displayed_dive here makes no sense for two reasons: 1) This is only called on startup, when displayed_dive is not yet initialized. 2) The tab-widgets don't use displayed_dive anyway. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel

desktop: use current_dive to save subtitles

2020-05-07T15:56:58Z

The old code used displayed_dive. However, virtually all the displayed data is now derived from current_dive. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel