subsurface.git/desktop-widgets/tab-widgets, branch v5.0.2

desktop: query DivePlannerPointsModel for planner state

2021-04-02T20:53:23Z

MainTab::updateDiveInfo() is not executed when in the planner. To decide whether the application is in the planner state, it queried the profile. Instead, query the DivePlannerPointsModel. Currently, there is no autoritative carrier of that flag. However, the MainTab has a dependency on DivePlannerPointsModel anyway, and therefore this removes a dependency on the profile. This brings us closer to a state where we can have multiple profiles. Ultimately, it is hoped that the whole check can be removed at this place, making the point moot. Signed-off-by: Berthold Stoeger

desktop: remove check for editMode in maintab

2021-04-02T20:53:23Z

The accept / reject message is only shown in edit-mode, no need to check it. This is a step in simplification / removal of the edit mode. Signed-off-by: Berthold Stoeger

profile: display arbitrary dive

2021-04-02T20:53:23Z

So far the profile operated on the global displayed_dive. Instead, take the dive to be displayed as a parameter to the plotDive() functions. This is necessary if we want to have multiple concurrent profile objects. Think for example for printing or for mobile where multiple dive objects are active at the same time. Signed-off-by: Berthold Stoeger

profile: detect dive-mode change in profile

2021-02-06T18:00:39Z

The profile must be replotted when the dive mode changes. Weirdly, this was routed via the dive-information tab (making it inherently non-mobile compatible). Detect such a change directly in the profile. Signed-off-by: Berthold Stoeger

desktop: don't access profile directly to redraw it

2021-02-06T18:00:39Z

The MainWindow has a function to replot the profile. Use that instead of accessing the profile directly. Signed-off-by: Berthold Stoeger

profile: remove ProfileWidget2::dateTimeChanged()

2021-01-10T23:57:39Z

This function sent a signal and the only listener was removed in the previous commit. Signed-off-by: Berthold Stoeger

desktop: rename Statistics tab to Summary

2021-01-03T21:56:25Z

We now have three different things that are kinda like statistics: - the summary tab (reasonably useful when looking at selected dives) - the yearly statistics (Ctrl/CMD-Y) - the full statistics (Ctrl/CMD-T) I'd argue that's at least one too many. But I'm sure some people will disagree. Signed-off-by: Dirk Hohndel

preferences: create global settingsChanged signal

2020-12-12T23:52:40Z

So far, the PreferencesDialog emitted a settingsChanged signal. This meant that models that listened to that signal had to conditionally compile out the code for mobile or the connection had to be made in MainWindow. Instead, introduce a global signal that does this and move the connects to the listeners to remove inter-dependencies. Signed-off-by: Berthold Stoeger

cleanup: remove empty function MainTab::reload()

2020-11-14T18:01:50Z

This used to reload the completion models. Moreover, remove two obsolete member-function declarations. Signed-off-by: Berthold Stoeger

desktop: automatically reload completion-models

2020-11-14T18:01:50Z

Instead of programatically reload the completion models, listen to the relevant signals in the models. To that goal, derive all the models from a base class. Signed-off-by: Berthold Stoeger