subsurface.git/desktop-widgets, branch master

desktop: fix div-by-zero when selecting multiple invalid dives

2021-10-11T17:53:41Z

Signed-off-by: Tim Segers

desktop/image-time-shift: use better filename filter

2021-09-22T16:09:12Z

We already have a function to select all supported image formats. Let's just use that. Signed-off-by: Dirk Hohndel

desktop/image-time-shift: reorder UI

2021-09-22T16:09:12Z

The camera sync feature has been moved above the Ok and Cancel buttons and given its own descriptive header. The checkbox to ignore unaligned image timestamps has been moved closer to the buttons. Signed-off-by: Tim Segers Signed-off-by: Dirk Hohndel

desktop/image: allow larger range for manual time shift

2021-09-22T16:09:12Z

The QTimeEdit field is severely limited when it comes to the supported time range. By coding our own input / validation we can allow far larger time shifts. For simplicity, this always assumes hours:minutes format. Signed-off-by: Dirk Hohndel

desktop: add support for camera sync delta of more than 24h

2021-09-22T16:09:12Z

When using the camera sync feature to sync media to the dive timeline, the calculated time difference was considered invalid if it was more than 24 hours. To prevent this, this commit disables the manual time offset input fields when the camera sync button is clicked. It then uses the epoch difference in the final offset calculation, enabling arbitrary time differences between camera and divecomputer. Signed-off-by: Tim Segers Signed-off-by: Dirk Hohndel

Re-do the libdivecomputer fingerprint save/load code

2021-09-19T23:51:46Z

This tries to make our fingerprinting code work better, by avoiding using the "deviceid" field that has always been unreliable because we've calculated it multiple different ways, and even for the same version of subsurface, it ends up changing in the middle (ie we calculate one value initially, then re-calculate it when we have a proper serial number string). So instead, the fingerprinting code will look up and save the fingerprint file using purely "stable" information that is available early during the download: - the device model name (which is a string with vendor and product name separated by a space) - the DC_EVENT_DEVINFO 32-bit 'serial' number (which is not necessarily a real serial number at all, but hopefully at least a unique number for the particular product) but because the model name is not necessarily a good filename (think slashes and other possibly invalid characters), we hash that model name and use the resulting hex number in the fingerprint file name. This way the fingerprint file is unambiguous at load and save time, and depends purely on libdivecomputer data. But because we also need to verify that we have the actual _dive_ associated with that fingerprint, we also need to save the final deviceid and diveid when saving the fingerprint file, so that when we load it again we can look up the dive and verify that we have it before we use the fingerprint data. To do that, the fingerprint file itself contains not just the fingerprint data from libdivecomputer, but the last 8 bytes of the file are the (subsurface) deviceid and the diveid of the dive that is associated with the fingerprint. Signed-off-by: Linus Torvalds

desktop: warn when deleting a cylinder with sensor readings

2021-09-03T20:35:28Z

This makes the sensors pointless and in the future, they will be removed. Signed-off-by: Berthold Stoeger

Remove the divecomputer naming tab

2021-08-18T20:22:02Z

The TabDiveComputer model won't work in the new world order, where you can't even insert a new device entry without a nickname to be edited. Signed-off-by: Linus Torvalds

desktop: fix crash when right-clicking of trip headers

2021-08-12T18:57:26Z

Commit e42fc1a1e9a13c77d3474dbcb26b68b8772b8c6d introduced a crash condition. Apparently the code attempts to test whether the clicked-on item is a top-level dive. The "Collapse others" menu item should not be shown in that case. It does this by testing "d->divetrip". However, "d" might quite logically be null if clicking on an unexpanded trip header. Therefore, check explicitly for the trip header case (which should show the menu item) and for good measure prevent the nullpointer access (that should be caught by testing for trip, but who knows). Fixes #3301. Signed-off-by: Berthold Stoeger

cleanup: replace membuffer by membufferpp in C-code

2021-07-23T18:22:43Z

Thus, the membuffer data is automatically freed when going out of scope - one thing less to worry about. This fixes one use-after-free bug in uploadDiveLogsDE.cpp and one extremely questionable practice in divetooltipitem.cpp: The membuffer was a shared instance across all instances of the DiveToolTipItem. Remves unnecessary #include directives in files that didn't even use membuffer. Signed-off-by: Berthold Stoeger