subsurface.git/desktop-widgets, branch v4.7.1

mainwindow: disable fullscreen support by default

2017-10-22T10:09:05Z

Require the FULLSCREEN_SUPPORT macro to enable fullscreen support. The toggle was added 4 years ago in Subsurface, but with the current version of Qt 5.9.x, it's very buggy on Windows and Ubuntu. While it's possible to make this work on Windows, it seems to behave broken in different ways on different versiosn of Ubuntu. Fixes #705 Signed-off-by: Lubomir I. Ivanov

Silence random warnings

2017-10-20T21:25:18Z

None of these seem to point to actual issues, so let's quiet them. Signed-off-by: Dirk Hohndel

Turn off Facebook debug messages unless verbose

2017-10-20T10:51:51Z

Signed-off-by: Dirk Hohndel

Use displayed_dc instead of current_dc

2017-10-19T18:57:02Z

current_dc is a macro that determines the dive computer based on the current dive number. When the planner is started from an emtpy dive list, the dive number ends up being -1 and that doesn't produce a valid dive computer. Use the divecomputer of the displayed_dive instead. This is done via a macro that can also be used in two other places. Without this patch, the planner crashed when called on an empty dive list. Signed-off-by: Robert C. Helling

Refuse to save an empty log to the clould

2017-10-19T11:37:47Z

This should prevent the problem of a user accidentally "deleting" their dives in the cloud by hitting "save to cloud" in the wrong moment. Signed-off-by: Robert C. Helling

printoptions.cpp: correctly remember the last selected template

2017-10-19T11:04:38Z

To find the last selected template index in the combo box, comparing against `printOptions->p_template` would work fine, except the `on_printTemplate_currentIndexChanged()` slot updates `printOptions->p_template` each time QComboBox::addItem() is called. This makes the `for` loop to add new combo box items and find the index of the last selected template not possible. To work around the issue, a local QString variable `storedTemplate` is introduced and it does not change during the `for` loop. Fixes #595 Signed-off-by: Lubomir I. Ivanov

Tags for geo references: Nicer look, translations and warning message

2017-10-17T10:12:07Z

For the geo references tags update the following: - Nicer look w/o "Tags:" text and brackets when inside location UI - Translation for "Tags:" - Warning message when no dive site layout categories are set Signed-off-by: Stefan Fuchs

Correct spelling for text in prefs georeferences

2017-10-17T10:12:07Z

Signed-off-by: Stefan Fuchs

Connect finished signal of download thread only once

2017-10-16T18:02:06Z

Connect finished signal of download thread only once in constructor of DownloadFromDCWidget instead of every time the Download / Cancel / Retry button is clicked. Fixes minor nuisance: On repeated download attempts multiple massage boxes were shown. Signed-off-by: Berthold Stoeger

Correctly name member function gasChange of DivePlannerPointsModel

2017-10-16T15:14:17Z

Signed-off-by: Stefan Fuchs