subsurface.git/desktop-widgets, branch v4.7.2

Postpone error message display if not in GUI thread

2017-10-31T23:32:08Z

Calls to report_error() crashed if not called from GUI thread. Fix this by postponing error message display if not in GUI thread. Code that creates a thread which possibly calls report_error() is responsible for calling MainWindow::showErrors() to flush the accumulated messages. Note that there is a race condition in report_error() and get_error_string(). Nevertheless, hitting it should be rather unlikely (two threads producing error messages at the same time) and hopefully it can be fixed rather easily. Signed-off-by: Berthold Stoeger

New dive plan set salinity to current dive salinity if dive selected

2017-10-30T20:45:56Z

This helps people who always use a std. salinity of e.g. 1020g/l. If they have a log with their dives open and plan a new dive they will have also for new planned dives the salinity set to their prefered value. Signed-off-by: Stefan Fuchs

Remove three obsolete preferences options for geocoding

2017-10-29T18:07:52Z

These options are not used any longer/were never used and can be removed to not confuse the users. Signed-off-by: Stefan Fuchs

mainwindow.cpp: fix whitespace

2017-10-28T15:39:19Z

Signed-off-by: Lubomir I. Ivanov

Set checked status of menu entry for dive list filter correctly

2017-10-28T12:16:38Z

When enabling the dive list filter via the menu entry "Log->Filter dives" and then switch off the filter via the small "close" button of the filter: Set the checked status of the menu entry correctly. Also set it correctly when switching on/off via the menu entry to avoid any situation where it is not synced. Signed-off-by: Stefan Fuchs

cloudstorage: better member name when updating authentication state

2017-10-26T18:44:02Z

This isn't just about showing the PIN or not. Signed-off-by: Dirk Hohndel

desktop UI: no longer attempt to manually show error notifications

2017-10-26T13:55:49Z

report_error() now does this automatically. So all these odd places in which we tried to make sure that we show errors are no longer needed. Signed-off-by: Dirk Hohndel

Divelistview: use report_error to report and error

2017-10-26T13:53:47Z

Signed-off-by: Dirk Hohndel

desktop UI: always show errors when reported

2017-10-26T13:50:53Z

Instead of waiting for a manual call to showError(), simply use the new callback to always immediately show the error in the notification widget. Signed-off-by: Dirk Hohndel

Fix broken multi selected dive to trip

2017-10-23T14:06:33Z

See referenced issue number. It leads back to an ancient (3 year old) commit 512c42e. Not sure this issue is introduced there, but that's not relevant. Key in reproducing this is the location where the context menu is requested (using the right mouse button). When it is the row next to the trip, the add-to-trip succeeds correctly, otherwise it is a no-op. The solution is rather trivial (in hindsight). Just loop over the selected dives, and try to find the trip we want to add to. Fixes: #522 Signed-off-by: Jan Mulder