subsurface.git/desktop-widgets, branch v4.7.4

Fix memory leak in download-from-dive-computer widget

2017-11-11T20:01:42Z

Instead of (re)allocating the vendor and product models, use the setStringList method on sub objects. Even though only a theoretical problem, the model objects are moved in front of the ui object, so that the widgets referencing the models are destroyed first. Signed-off-by: Berthold Stoeger

Initialize Facebook page only when dialog is shown

2017-11-10T18:04:28Z

Quick hack to avoid Facebook access on every program start. Move the initialization of the login page from the FacebookConnectWidget constructor to the show event handler. Signed-off-by: Berthold Stoeger

preferences: support a pre-defined list of time formats

2017-11-10T17:21:47Z

Add a combo-box that holds a list of pre-defined time formats in the Language preferences. The user is still allowed to enter a custom time format. Signed-off-by: Lubomir I. Ivanov

preferences: re-use a tr() string in _language.cpp

2017-11-10T17:21:47Z

Also, tell "in date format" instead of "in time format" for dates. Signed-off-by: Lubomir I. Ivanov

preferences: support a pre-defined list of date formats

2017-11-10T17:21:47Z

Add a combo-box in place of the single line text field and support some pre-defined date formats, such as: MM/dd/yyyy Each long format has a corresponding short variant stored in the QMap dateFormatShortMap and it's updated automatically once the user selects a combo box item for the long format. The regex for dates is slighly modified: [^dMy/\\s:;\\.,\\-] The user is still allowed to enter custom long / short date foramats. Fixes #276 Signed-off-by: Lubomir I. Ivanov

map-widget: allow real-time updates of edited markers

2017-11-09T20:40:25Z

This patch allows updating the location of map markers while editing a dive site and updating the text in the LocationInformationWidget in real-time. Currently it is only possible to see the marker changes by clicking 'Apply'. The modification required the following changes: - add the MapWidget::updateCurrentDiveSiteCoordinatesToMap() slot and call it each time the GPS text updates - separate the updateCurrentDiveSiteCoordinates(FromMap/ToMap) logic by having the FromMap/ToMap suffix to method names - make MapWidgetHelper::updateCurrentDiveSiteCoordinatesToMap() call a new MapLocationModel::updateMapLocationCoordinates() method, which updates selected location coordinates and the model - add MapLocation::setCoordinateNoEmit() that does not emit a signal when updating a coordinate Signed-off-by: Lubomir I. Ivanov

BT device selection dialog: make Save the default button

2017-11-06T22:05:26Z

When a user presses enter, they probably want their selection saved, not discarded. Signed-off-by: Berthold Stoeger

Remove unnecessary == NULL test.

2017-11-06T22:05:26Z

Test not necessary, because the QString in question is not a pointer and the string is tested for emptiness (which also flags null-strings). Signed-off-by: Berthold Stoeger

map-widget: move the widget and its resources to 'map-widget'

2017-11-05T22:48:56Z

Move all the map widget platform agnostic files to the /map-widget folder. This avoids the confusion about the desktop version of subsurface using mobile components. The map widget is planned as a shared component between the mobile and desktop versions. desktop-widgets/mapwidget[.h/.cpp] still remain as those are specific to the desktop version. Signed-off-by: Lubomir I. Ivanov

Replace itemClicked() by currentItemChanged() in Bt device selection

2017-11-04T16:27:24Z

This fixes two problems: 1) Using the keybord or clicking below the list and moving the mouse up while holding the mouse button did not properly update the status message and the save button. For example, one could save with a non- paired device selected. 2) The code assumed that a device is selected if the save button is active, but the save button was not disabled on scan. Thus, one could provoke a crash by selecting an item, scanning and then pressing save. This problem is fixed indirectly, because the save button is now always disabled if the selection is cleared. Signed-off-by: Berthold Stoeger