subsurface.git/desktop-widgets, branch v4.7.7forked from https://github.com/subsurface/subsurfacehttps://git.tsegers.com/subsurface.git/atom?h=v4.7.72018-02-04T21:40:32Zdownloadfromdivecomputer.cpp: remove unused variable err_string2018-02-04T21:40:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-02-04T11:35:13Zurn:sha1:a3d61c157578c84d07ebe18984f6552c34297f74
This was a relict from Gtk days.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Cleanup: Remove redefinition of DC_TRANSPORT_BLUETOOTH2018-02-04T21:40:32ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-02-03T22:21:53Zurn:sha1:7fc3a345ffb55eb92437a67def2e3748d8a4df73
This transport option was defined at a time where libdc didn't know
anything about bluetooth. Nowadays, this enum is defined by libdc to
a different value.
Since it is never returned from libdc, not a problem at the moment.
But this looks like a recipe for desaster, therefore let's just use
the libdc version.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Do not remove seconds from duration input field2018-02-04T21:40:02ZOliver Schwanebergoliver.schwaneberg@gmail.com2018-02-04T19:07:32Zurn:sha1:eb38a641490752578e3dddc7b7959cfd52e0be74
This change deals with issue #554.
If you enter a dive duration manually, the cell renderer cuts the seconds
away when the changes are saved. I added the helper "render_seconds_to_string"
as a counterpart to "parseDurationToSeconds". The helper keeps the seconds,
if not null. The rendering of the cell is done at two places in the code,
so I think it is cleaner to add a dedicated method for it.
Signed-off-by: Oliver Schwaneberg <oliver.schwaneberg@gmail.com>
Free various struct membuffer in different functions2018-02-02T19:29:55ZStefan Fuchssfuchs@gmx.de2018-01-22T19:29:55Zurn:sha1:b5ce06c8b958cdc51761c31697189db81baf4423
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
Make report_error() reentrant2018-01-31T13:47:26ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-01-26T09:40:04Zurn:sha1:8f81a22e7f26729cc2f4902ba7db8f696314539f
Remove the global error buffer and pass the error string directly
to the frontend. The frontend is then responsible for accumulating
errors.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Remove unnecessary check for MainWindow instance2018-01-31T13:47:26ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-01-26T17:39:46Zurn:sha1:df81a39aa5d10fd12928a1bef7fdf31e0050e439
The error-callback is installed in the MainWindow constructor.
Therefore, in the error-callback the existence of the MainWindow
instance is guaranteed.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Use queued connection to thread-safe MainWindow error handling2018-01-31T13:47:26ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-01-28T21:08:30Zurn:sha1:a25f54e3c29a936bb1bbfa66fa610c31c9b55808
Up to now, errors produced by threads were not directly shown in
the MainWindow. Code running in the GUI thread had to manually
show the errors.
This can be simplified by using Qt's queued connection as message
passing facility.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Make future_watcher a subobject of NotificationWidget2018-01-31T13:47:26ZBerthold Stoegerbstoeger@mail.tuwien.ac.at2018-01-28T20:50:25Zurn:sha1:1704e0801258d0ae78b18be32488e083458010f1
This was a raw pointer. No point in doing error-prone manual
memory management.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Use correct alias for satellite icon for revers geo lookup2018-01-27T20:29:00ZStefan Fuchssfuchs@gmx.de2018-01-27T20:03:42Zurn:sha1:79ce3c02cbb67a568e50c95b1f2f227a3265af86
Bring back the satellite icon for the reverse geo lookup by using
the correct alias name.
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
Whitespace only2018-01-18T08:44:08ZJan Mulderjlmulder@xs4all.nl2018-01-16T13:15:31Zurn:sha1:e592dfe17c5a1a6d2b714752f5b27e9d531de9bb
Now that we properly return when raising an error, do not
if () else if(). Useles.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>