subsurface.git/desktop-widgets, branch v4.7.8

Add "Tags" column in Desktop app's dive list view

2018-04-04T11:10:45Z

Add DiveItem::displayTags helper method to return Tags as a QString New Tags column is by default inserted before "Photos" column by default disabled Signed-off-by: Jeremie Guichard

Revert "GPS: use applyGpsLocation::applyLocations from core"

2018-04-03T18:52:46Z

This reverts commit 70e0e80de5470216df939f994ffda0222560def0. This caused the GPS workflow to break for Linus. Let's revert for 4.7.8 and figure out how to do this cleanup correctly, later. Signed-off-by: Dirk Hohndel

Revert "cleanup: localize global variable"

2018-04-03T18:52:19Z

This reverts commit fc7729eb78e7dae803546b3cc0011260e779a2e8. This caused the GPS workflow to break for Linus. Let's revert for 4.7.8 and figure out how to do this cleanup correctly, later. Signed-off-by: Dirk Hohndel

Dive pictures: Move metadata functions into own translation unit

2018-04-01T13:04:48Z

Move all metadata function into new core/metadata.cpp file. Signed-off-by: Berthold Stoeger

Profile heatmap/heartrate: Only enable max one of these at same time

2018-03-19T22:44:02Z

Only allow to enable maximum one of both items tissue heatmap or heartrate in profile. This is done by always switching off the other one at the moment you turn on one of the two items (heatmap or heartrate). Signed-off-by: Stefan Fuchs

Cleanup: Initialize variable MainTab::lastSelectedDive

2018-03-19T15:54:31Z

This variable was read before being set. Signed-off-by: Berthold Stoeger

Cleanup: consistently use toUtf8() instead of toLocal8Bit()

2018-03-14T11:55:36Z

These do the same, since the text-codex is set to UTF-8 on startup. Signed-off-by: Berthold Stoeger

Cleanup: introduce copy_qstring() function

2018-03-14T11:55:36Z

strdup(qPrintable(s)) and copy_string(qPrintable(s)) were such common occurrences that they seem worthy of a short helper-function. Signed-off-by: Berthold Stoeger

Cleanup: consistently use qPrintable()

2018-03-14T11:55:36Z

Replace constructs of the kind s.toUtf8().data(), s.toUtf8().constData(), s.toLocal8Bit().data(), s.toLocal8Bit.constData() or qUtf8Printable(s) by qPrintable(s). This is concise, consistent and - in principle - more performant than the .data() versions. Sadly, owing to a suboptimal implementation, qPrintable(s) currently is a pessimization compared to s.toUtf8().data(). A fix is scheduled for new Qt versions: https://codereview.qt-project.org/#/c/221331/ Signed-off-by: Berthold Stoeger

Cleanup: Fold add_hash() call into learnHash() function

2018-03-05T16:04:57Z

learnHash() was always called in conjunction with add_hash(). The pattern was that a local filename and a hash were connected in the hash-to-filename and the filename-to-hash maps. Then, the original picture-filename or url were registered in the filename-to-hash map. This commit changes learnHash() to take three parameters (original-filename, local-filename and hash) and do all of the above. The new code is simpler because no dummy picture struct has to be generated in DiveListView::loadImageFromURL(). The tests were extended to check for all hash<->filename associations. Signed-off-by: Berthold Stoeger