subsurface.git/desktop-widgets, branch v4.8.1

Code cleanup in diveplanner.cpp

2018-07-13T18:26:28Z

Move a variable declaration and added some initialization. Added missing spaces. Signed-off-by: Stefan Fuchs

Fix configure bluetooth ostc's

2018-07-13T16:44:33Z

When we introduced the whole check for supported transports code, no one noticed that it broke configuring all ostc's over bluetooth. The configure code just used a placeholder model of OSTC 3 to get the right backend code. With the new supported transports model it errored out if you where trying to connect to a bluetooth enabled device, just because the original OSTC 3's wasn't bluetooth enabled. This switches the placeholder model over to a OSTC Plus which is both bluetooth, serial and ble capable, so the code works again. Signed-off-by: Anton Lundin

desktop-widget: move qmlRegister from mapwidget to shared helper

2018-07-12T15:08:00Z

Remove qmlRegister in desktop-widgets/mapwidget in order to have a shared registration in subsurface-helper.cpp Signed-off-by: Jan Iversen

core: make qPref::cloud_status the only version of the enum

2018-07-10T17:30:50Z

add enum to qPref and remove elsewhere update source core to reference qPref. the enum cannot be in pref.h because it is to be used in qml and Q_ENUM need the enum to be defined as part of the class Signed-off-by: Jan Iversen

Translations: unify gettextFromC::tr() and QObject::tr()

2018-07-03T21:33:31Z

There were two catch-all classes for translations outside of class context. gettextFromC was used exclusively from C, but C++ used both, gettextFromC and QObject. Some of the string were even present in both. Therefore, unify to gettextFromC throughout the code base. Signed-off-by: Berthold Stoeger

core: remove double definition of enum cloud_storage_status

2018-07-03T21:32:30Z

Remove cloud_storage_status from qmlprefs.h. usage to qPref:: enum cloud_storage_status is not used from C, but only from C++, and having the same structure defined multiple times is a maintenance challenge. Signed-off-by: Jan Iversen

Dive pictures: implement FindMovedImagesDialog

2018-07-03T18:27:36Z

Move the find-moved-images functions into a new translation unit and present the user with the identified matches before applying them. Signed-off-by: Berthold Stoeger

Dive pictures: remove hashes

2018-07-03T18:27:36Z

In the last commits, the canonical-to-local filename map was made independent from the image hashes and the location of moved images was based on filename not hashes. The hashes are now in principle unused (except for conversion of old-style local filename lookups). Therefore, remove the hashes in this commit. This makes addition of images distinctly faster. Signed-off-by: Berthold Stoeger

Dive pictures: find moved pictures based on filename

2018-07-03T18:27:36Z

Users might have edited their pictures. Therefore, instead of identifying pictures by the hash of the file-content, use the file path. The match between original and new filename is graded by a score. Currently, this is the number of path components that match, starting from the filename. Camparison is case-insensitive. After having identified the matching images, write the caches so that they are saved even if the user doesn't cleanly quit the application. Since the new code uses significantly less resources, it can be run in a single background thread. Thus, the multi-threading can be simplified. Signed-off-by: Berthold Stoeger

Dive pictures: index local file name by canonical filname

2018-07-03T18:27:36Z

The connection canonical filename to local filename was done via two maps: 1) canonical filename -> hash 2) hash -> local filename But the local filename was always queried from the canonical filename. Therefore, directly index the former with the latter. On startup, convert the old map to the new one. Signed-off-by: Berthold Stoeger