subsurface.git/desktop-widgets, branch v4.8.2forked from https://github.com/subsurface/subsurfacehttps://git.tsegers.com/subsurface.git/atom?h=v4.8.22018-09-16T15:07:33ZDesktop UI: small layout correction export dialog2018-09-16T15:07:33ZJan Mulderjlmulder@xs4all.nl2018-09-16T12:37:59Zurn:sha1:7efcb0594c7d5f12980e8f569234abc4534924e9
2 UI items where poorly aligned. Fixed here.
Reported-by: willemferguson <willemferguson@zoology.up.ac.za>
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
code cleanup: replace lring with file local function2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-13T15:45:14Zurn:sha1:7319b50a5d7c46abd7495aa51740ec6cb0ec0141
And simplify the code.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: no need for default if we test every case2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-14T14:49:42Zurn:sha1:77d7e550feb6b7d6bce8a470d53fe087af5a1851
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: use ByteArray.size() instead of strlen2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-14T14:49:18Zurn:sha1:7ab35f7858c8d840cf098de82f6b6265e4ec7b8b
Removes a size_t vs int warning
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: pre-calculate the test and pass it directly2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-14T14:48:51Zurn:sha1:00ef514da387b63311a6d02afc2e0cf9bdf9d05c
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: allocate the vector in one go2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-14T14:47:23Zurn:sha1:6d552d61b941dbc3a018ba46afdf27812bee2073
The << alternative can reallocate the vector, but we know it's size, so
preallocate.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: simplify if / else chains2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-13T16:08:26Zurn:sha1:858740e8a1ad9b0febb1f805cccf1f943062375b
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: remove allocations2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-15T15:26:35Zurn:sha1:9e6a3bee0d029205169896dc9d2b39f421a3039a
Simply create the string in one go.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: use nullptr in C++ files2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-15T15:25:10Zurn:sha1:2d6633eee04de7ce2315ecf141267e50babe1ffa
Using 0 or NULL are C idioms.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
code cleanup: unamed namespace instead of global or static variables2018-09-15T22:51:26ZTomaz Canabravatcanabrava@kde.org2018-09-13T15:55:47Zurn:sha1:17a6f288277514ad4e9a44610b7b3b023c69f3cb
Unamed namespace behaves the same way as static variables in C source.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>