subsurface.git/desktop-widgets, branch v4.8.3

Parser: parse text-based files into arbitrary table

2018-09-28T22:06:00Z

In d815e0c9476ef62e6b84fb28ce48ab7cddefe77e a dive_table pointer was added to the parsing functions to allow parsing into tables other than the global dive table. This will be necessary for undo of import and implementation a cleaner interface. A few cases, notably CSV and proprietary formats were forgotten. Implement parsing into arbitrary tables also for these cases. Signed-off-by: Berthold Stoeger

Cleanup: remove redundant prototypes from dive.h

2018-09-28T14:47:39Z

A few of these prototypes were already in import-csv.h. Put them in an 'extern "C" { ... }' block. Signed-off-by: Berthold Stoeger

Desktop/remember DCs: insert the remember connection into dropdown

2018-09-24T16:51:21Z

This still doesn't do the right thing for BT/BLE connections on a Mac, but it should work on Linux and possibly Mac. We definitely need to figure out how to get the Mac to successfully connect back to a BT/BLE device. Signed-off-by: Dirk Hohndel

Core: split process_dives() in post-import and post-load versions

2018-09-23T18:50:53Z

process_dives() is used to post-process the dive table after loading or importing. The first parameter states whether this was after load or import. Especially in the light of undo, load and import are fundamentally different things. Notably, that latter should be undo-able, whereas the former is not. Therefore, as a first step to make import undo-able, split the function in two versions and remove the first parameter. It turns out the the load-version is very light. It only sets the DC nicknames and sorts the dive-table. There seems to be no reason to merge dives. Signed-off-by: Berthold Stoeger

Desktop/settings: hook up button to clear remembered DCs

2018-09-23T18:49:30Z

And at least admit that the reset settings button isn't hooked up at all. OOOOPS. Signed-off-by: Dirk Hohndel

Desktop/settings: add button to forget remembered dive computers

2018-09-23T18:49:30Z

This isn't hooked up, yet. Signed-off-by: Dirk Hohndel

Desktop/remember DCs: avoid highlighted button

2018-09-23T18:49:30Z

On macOS the first of the four DC buttons was highlighted for some reason. Explicitly setting autoDefault to no solved that problem. Signed-off-by: Dirk Hohndel

Desktop/remember DCs: move non-UI-specific code into the core layer

2018-09-23T18:49:30Z

This way we can use the same functionality from the mobile UI as well. Signed-off-by: Dirk Hohndel

Desktop/remember DCs: hook up the shortcut buttons

2018-09-23T18:49:30Z

The straight forward code to update the currentIndex of the combobox doesn't appear to work on macOS (but works fine on Linux). Calling the event loop and then calling update afterwards seems very unintuitive, but it appears to fix the issue in my testing. Signed-off-by: Dirk Hohndel

Desktop/remember DCs: remember dive computers that were used

2018-09-23T18:49:30Z

The algorithm tries to keep the order of the buttons the same. So if a dive computer was used that's already remembered, don't reorder the buttons. But if a new dive computer is used, add it as the first one and move the others back, potentially dropping the oldest one. Signed-off-by: Dirk Hohndel