subsurface.git/desktop-widgets, branch v4.9.0

Fixed filter scrollarea not adjusting to parent height

2019-07-13T16:38:40Z

Changed the Qt Layout for FilterWidget2 to "Lay Out on a Grid" to allow the scrollarea to adjust when the height of FilterWidget2 changes. Fixes issues #2174. Signed-off-by: Doug Junkins

Desktop: clear notes on empty dive

2019-07-11T13:58:30Z

If no dive is set, all fields except the note field were cleared. Also clear notes. Fixes #2172 Reported-by: Anton Lundin Signed-off-by: Berthold Stoeger

Preferences: warn if ffmpeg can't be loaded

2019-07-10T15:24:23Z

In the preferences widget warn the user when they enter a non-executable path to ffmpeg. Thus they don't have to start thumbnailing just to find out that the path is wrong. Signed-off-by: Berthold Stoeger

Desktop: update BT selection when picking remembered dive computer

2019-07-09T19:41:04Z

When switching to a BT dive computer, the device selection dialog is opened, when switching away from BT, the device address is set. Fixes #2139 Signed-off-by: Dirk Hohndel

Desktop: reduce minimum vertical size

2019-07-04T08:21:23Z

The Filter widget really needed to be scrollable as it is very tall. Fixes #2152 Signed-off-by: Dirk Hohndel

Cleanup: remove DiveLocationLineEdit::currType

2019-07-04T01:41:09Z

Apparently this field was never used...? Signed-off-by: Berthold Stoeger

Desktop: enable clearing of dive site

2019-07-04T01:41:09Z

Clearing dive site did not work for two reasons: 1) We didn't get a signal when editing was finished. 2) When clearing the dive site, the "add new dive site" site was set. Thus, connect to the editingFinished signal and in DiveLocationLineEdit::currDiveSite() return a null pointer if the string is empty. This means that it is not possible to have a dive site with an empty string, but that shouldn't be a problem, right? Fixes #2148 Signed-off-by: Berthold Stoeger

Cleanup: avoid spurious updateDiveInfo() calls

2019-07-04T01:40:47Z

In 2e230da3610dd1fc61badaf328a084512895fb90 the dive-selection signals were unified. Sadly, this was done in a suboptimal way resulting in numerous calls to updateDiveInfo(), which refreshes the main-tab. Firstly, the MainWindow connected to selection changes from both, the undo-command and the divelist. Secondly, every selected dive in the divelist caused a single signal. Thus, connect only to the divelist (this is necessary for user-initiated selection changes) and only send a single signal in the divelist per selection-reset. This is still less than perfect as updateDiveInfo() is called even if the current dive doesn't change. Signed-off-by: Berthold Stoeger

Dive merge: don't use unset dive numbers

2019-06-28T11:23:01Z

On merging, don't use the number of the first dive if it is 0. Use the first non-zero number. Fixes #2126 Signed-off-by: Berthold Stoeger

Desktop: small optimization

2019-06-24T11:01:25Z

This way we don't need to iteratively grow the QVector. Suggested-by: Berthold Stoeger Signed-off-by: Dirk Hohndel