subsurface.git/desktop-widgets, branch v4.9.1

Desktop: correct tooltip for filter close button

2019-07-29T05:24:05Z

This button only closes the filter panel but doesn't clear it. Reported-by: Adric Norris Signed-off-by: Dirk Hohndel

Desktop: fix index in weightsystems_equal()

2019-07-27T18:51:34Z

The weightsystem_equal() function compares weightsystems of two dives to decide whether the "commit changes" message should be shown and to decide which dives are edited when changing multiple dives. Due to an index mixup the function returned wrong results for more than two weightsystems. Fix it. Signed-off-by: Berthold Stoeger

Undo: make editing of dive number undoable

2019-07-20T04:44:13Z

When pressing F2 in the dive list, the number can be edited. Make this action undoable by implementing a EditNumber command. This command is differs from the other undo commands, as not the currently selected dives are changed. This means that the EditCommand needs an alternative constructor taking a single dive. This constructor was implemented in the base class so that all edit commands can now be called with a single dive. Signed-off-by: Berthold Stoeger

Core: dynamically resize weight table

2019-07-18T13:01:07Z

Replace the fixed-size weightsystem table by a dynamically relocated table. Reuse the table-macros used in other parts of the code. The table stores weightsystem entries, not pointers to weightsystems. Thus, ownership of the description string is taken when adding a weightsystem. An extra function adds a cloned weightsystem at the end of the table. Signed-off-by: Berthold Stoeger

Cleanup: Remove unused function calls in main tab

2019-07-18T12:47:27Z

per_cylinder_mean_depth() and selected_dives_gas_parts() are used in the dive-information and statistics tab, respectively. Nevertheless, these functions are called on the main tab as well and the result is trashed. Therefore remove the calls. Must have been an artifact. Signed-off-by: Berthold Stoeger

Cleanup: remove includes from qthelper.h

2019-07-18T12:42:55Z

To reduce interdependencies, remove the dive.h and divelist.h includes in qthelper.h Signed-off-by: Berthold Stoeger

Cleanup: move deco function declarations to deco.h

2019-07-18T12:42:55Z

Another tiny step in making dive.h smaller: move function declarations to deco.h if these functions are defined in deco.c and don't directly concern dives. Signed-off-by: Berthold Stoeger

Cleanup: remove includes from qt-models/models.h

2019-07-18T12:42:55Z

qt-models/models.h included dive.h and divelist.h. Remove these unnecessary includes, to reduce interdependencies. A drop in the bucket, for sure. Signed-off-by: Berthold Stoeger

Fixed filter scrollarea not adjusting to parent height

2019-07-13T16:38:40Z

Changed the Qt Layout for FilterWidget2 to "Lay Out on a Grid" to allow the scrollarea to adjust when the height of FilterWidget2 changes. Fixes issues #2174. Signed-off-by: Doug Junkins

Desktop: clear notes on empty dive

2019-07-11T13:58:30Z

If no dive is set, all fields except the note field were cleared. Also clear notes. Fixes #2172 Reported-by: Anton Lundin Signed-off-by: Berthold Stoeger