subsurface.git/desktop-widgets, branch v4.9.2

Desktop: fix crash on copy & paste

2019-08-24T21:00:06Z

The constructor of PasteState was clearing an uninitialized weightsystem-table. Very silly. Initialize it instead. Fixes #2253 Reported-by: Stefan Fuchs Signed-off-by: Berthold Stoeger

Cleanup: turn CylinderObjectHelper into value type

2019-08-22T17:13:40Z

CylinderObjectHelper is used for structured formatting of cylinder values in grantlee types. Instead of keeping a reference to a cylinder, turn it into a value type containing the formatted strings. This should be distinctly safer, as we don't risk having stale references flying around. Moreover, we don't have to use pointers but can use containers containing plain CylinderObjectHelper. Thus, no explicit memory management is needed, making the code distinctly easier to understand. Sadly, currently grantlee does not support Q_GADGET based Q_PROPERTY. Therefore a GRANTLEE_*_LOOKUP block has to be added. This can be removed in due course, as a patch to remedy this issue is in current grantlee master. Signed-off-by: Berthold Stoeger

Desktop: show local git repos in recent files

2019-08-18T20:37:17Z

But don't show our cloud storage entry (as that is already in the File menu, anyway). This is extremely useful because while you can manually enter a file name to save to (and therefore can use the 'magic' git repo syntax), on most OSs there is no way to enter that non-existing 'file name' (which is the git branch in square brackets) in the file open dialog. Fixes: #2236 Signed-off-by: Dirk Hohndel

Cleanup: move file-related function declarations to file.h

2019-08-08T23:26:31Z

A number of architecture-dependent functions were declared in dive.h. Move them to file.h so that not all file-manipulating translation units have to include dive.h. This is a small step in avoiding mass-recompilation on every change to dive.h Signed-off-by: Berthold Stoeger

Cleanup: move error reporting function declarations to errorhelper.h

2019-08-08T23:26:30Z

Move the declarations of the "report_error()" and "set_error_cb()" functions and the "verbose" variable to errorhelper.h. Thus, error-reporting translation units don't have to import the big dive.h header file. Signed-off-by: Berthold Stoeger

Move the Suit text box from the Notes tab to the Equipment tab

2019-08-08T16:12:09Z

Sqash latest commit with previous one. Signed-off-by: willemferguson

Desktop: display trip time on main-tab

2019-08-08T16:03:33Z

On the main tab, the trip time was not shown when switching to a trip. Implement showing of the trip date in a function, as the undo-code will also have to update the trip date in certain circumstances. Fixes #2207 Signed-off-by: Berthold Stoeger

Desktop: correct tooltip for filter close button

2019-07-29T05:24:05Z

This button only closes the filter panel but doesn't clear it. Reported-by: Adric Norris Signed-off-by: Dirk Hohndel

Desktop: fix index in weightsystems_equal()

2019-07-27T18:51:34Z

The weightsystem_equal() function compares weightsystems of two dives to decide whether the "commit changes" message should be shown and to decide which dives are edited when changing multiple dives. Due to an index mixup the function returned wrong results for more than two weightsystems. Fix it. Signed-off-by: Berthold Stoeger

Undo: make editing of dive number undoable

2019-07-20T04:44:13Z

When pressing F2 in the dive list, the number can be edited. Make this action undoable by implementing a EditNumber command. This command is differs from the other undo commands, as not the currently selected dives are changed. This means that the EditCommand needs an alternative constructor taking a single dive. This constructor was implemented in the base class so that all edit commands can now be called with a single dive. Signed-off-by: Berthold Stoeger