subsurface.git/desktop-widgets, branch v4.9.6

Fix includes for building against Qt-5.15

2020-06-13T12:00:05Z

Signed-off-by: Gaetan Bisson

cleanup: remove QCalendarWidget forward declaration and include

2020-05-27T20:55:08Z

This is an artifact of code that never came to be. Signed-off-by: Berthold Stoeger

cleanup: unglobalize grayImage()

2020-05-27T20:55:08Z

This function was globalized in be462ae1a6 to be used for the calender widget, but that never came to be. Therefore, for now unglobalize it until it is needed. That said, there probably is a helper function to turn pictures into gray-scale. Signed-off-by: Berthold Stoeger

cleanup: un-singletonize ShiftTimesDialog

2020-05-27T16:47:35Z

There is no reason that this dialog is a singleton. Since it is modal, it can be created on demand. Apart from removing superfluous global state, this simplifies code, because preparing the widget can now be done in the constructor instead of overriding the showEvent() function. Signed-off-by: Berthold Stoeger

cleanup: un-singletonize RenumberDialog

2020-05-27T16:47:35Z

There is no reason that this dialog is a singleton. Since it is modal, it can be created on demand. This simplifies code, because the mode (selected-only or all-dives) can be set in the constructor. Signed-off-by: Berthold Stoeger

cleanup: whitespace fixes in TabDiveInformation

2020-05-25T15:33:08Z

Use C-style function definitions (squirly brackets on new lines) and remove empty lines at end of file. Signed-off-by: Berthold Stoeger

desktop: localize salinity value

2020-05-25T15:33:08Z

The salinity value was not displayed with localized thousands separators. E.g. to a user of a German locale the density read as slightly over 1 g/l, when it should be approximately 1000 g/l. For consistency, also localize that value. Also localize the CNS and OTU numbers, even though these should (hopefully!) never come with thousands separators. Signed-off-by: Berthold Stoeger

cleanup: create common QDateTime -> timestamp conversion function

2020-05-22T19:31:06Z

In analogy to the timestamp -> QDateTime conversion, create a common function. 1) For symmetry with the opposite conversion. 2) To remove numerous inconsistencies. 3) To remove use of the deprecated QDateTime::toTime_t() function. Signed-off-by: Berthold Stoeger

cleanup: move timestampToDateTime() to qthelper.cpp

2020-05-22T19:31:06Z

Move this function from maintab.cpp to qthelper.cpp. Since the functionality was used in numerous places, use the helper function there as well. This removes a number of inconsistencies. For example, sometime setTimeSpec(Qt::UTC) was called, even though the QDateTime object was already created with that time spec. Signed-off-by: Berthold Stoeger

desktop: update date and time fields if user changes format

2020-05-22T17:00:43Z

This was more painful than expected, because we get the "preferences" changed signal too early when the user switches to system format. The correct format is set by the preferences-widget, not the preferences subsystem. Signed-off-by: Berthold Stoeger