subsurface.git/desktop-widgets, branch v5.0.1

stats: fix visibility check of the statistics tab on desktop

2021-03-31T11:41:39Z

Apparently, the visibility flag of the view is not inherited from the statistics widget. Therefore, the statistics is redrawn on every action even if not visible. Set the visibility explicitly in the show- and hide-events. This is crazy. Signed-off-by: Berthold Stoeger

desktop: fold ApplicationState into MainWindow

2021-02-17T15:26:55Z

The application state is a desktop-only thing. The mobile UI also has its application state, but that is something completely different. The last remaining user of the application state was to flag whether the planner is active. Since this has all been unglobalized, the ApplicationState structure can be moved from core to the desktop UI. And there it can be made local to the MainWindow class. Signed-off-by: Berthold Stoeger

planner: pass in_planner down to TemplateLayout

2021-02-17T15:26:55Z

The TemplateLayout prints different dives depending on whether the planner is active. Instead of accessing a global variable, pass the status down from the MainWindow. That's all quite convoluted, since there are multiple layers involved. On the positive side, the in_planner() function has now no users an can be removed. Signed-off-by: Berthold Stoeger

cleanup: remove unused includes in mainwindow.cpp

2021-02-17T15:26:55Z

The printing code moved elsewhere, so these includes are not needed. Signed-off-by: Berthold Stoeger

statistics: implement primitive "restrict to selection" feature

2021-02-13T21:02:54Z

Allow the user to restrict the analyzed dives based on the current selection. One button restricts to the current selection and one button resets the restriction. Thus, the user can for example select bars in the bar chart or a range in the scatter plot and perform statistics on these sets. The restriction works on top of the filter. The UI can certainly be improved, but it is a start. Signed-off-by: Berthold Stoeger

printing: "fix" progress indicator

2021-02-13T20:20:25Z

In TemplateLayout, there was a progress indication, which reported the progress - not of the actual rendering - but of adding the dives to the "to render" list. Which is of course done in less than a ms, making the whole thing completely pointless. Instead, emit progress when actually looping over the dives or statistics. Nobody ever noticed the problem because even rendering is done in fractions of a second and indeed is accounted to only one fifth of the total progress. The real purpose of this "fix" is to get rid of the getTotalWork() function, which was just insane. Instead of asking the TemplateLayout how many dives it rendered, this number was extracted from global state. Simply store the number of dives in the TemplateLayout object instead. Moreover, fix two coding style issues: - "Page" variable identifier starting with a capital - The Printer::render() being defined (as opposed to declared) with a default parameter. This is not how C++'s default parameters work, sorry. Signed-off-by: Berthold Stoeger

desktop: disable animation when selecting multiple dives

2021-02-10T22:33:15Z

Selecting many dives when the animation was active was increadibly slow, so disable it. Signed-off-by: Berthold Stoeger

desktop: improve splitter defaults

2021-02-06T18:00:39Z

On first startup, use the splitter values suggested by Dirk: Top/Bottom: 60/40 Info/Profile: 50/50 List/Map: 60/40 Signed-off-by: Berthold Stoeger

profile: detect dive-mode change in profile

2021-02-06T18:00:39Z

The profile must be replotted when the dive mode changes. Weirdly, this was routed via the dive-information tab (making it inherently non-mobile compatible). Detect such a change directly in the profile. Signed-off-by: Berthold Stoeger

desktop: be smarter about filling splitters

2021-02-06T18:00:39Z

On state change, the splitters were completely emptied and refilled. Instead try to reuse already existing splitter slots. This reduces annoying flickering. Signed-off-by: Berthold Stoeger